Skip to content

Align Spinner circles in RTL locales - #14418

Merged
youknowriad merged 1 commit into
WordPress:masterfrom
Aljullu:fix/rtl-spinner-misalignment
Mar 14, 2019
Merged

youknowriad merged 1 commit into
WordPress:masterfrom
Aljullu:fix/rtl-spinner-misalignment

Conversation

@Aljullu

@Aljullu Aljullu commented Mar 13, 2019

Copy link
Copy Markdown
Contributor

Description

Fixes #14417.

Using a RTL locale, the Spinner circles were misaligned (see screenshots below).

We found this issue while working on adding RTL support to wc-admin: woocommerce/woocommerce-admin#1776

How has this been tested?

Verifying it renders correctly in the browser. It's a small CSS change, so it shouldn't affect other parts of the codebase.

Screenshots

Before:
spinner-before

After:
spinner-after

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Aljullu
Aljullu requested a review from chrisvanpatten as a code owner March 13, 2019 17:02
@Aljullu Aljullu mentioned this pull request Mar 13, 2019
18 tasks done
@swissspidy swissspidy added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Mar 14, 2019
@youknowriad

Copy link
Copy Markdown
Contributor

Thanks for the contribution :)

@youknowriad
youknowriad merged commit 589a634 into WordPress:master Mar 14, 2019
@Aljullu
Aljullu deleted the fix/rtl-spinner-misalignment branch March 14, 2019 12:46
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Mar 15, 2019
@youknowriad youknowriad added this to the 5.3 (Gutenberg) milestone Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spinner misalignment in RTL locales

3 participants