Skip to content

Add fallback to string if getAttribute returns null - #1427

Merged
youknowriad merged 1 commit into
WordPress:masterfrom
nagayama:update/fix-format-toolbar-warning
Jun 26, 2017
Merged

youknowriad merged 1 commit into
WordPress:masterfrom
nagayama:update/fix-format-toolbar-warning

Conversation

@nagayama

@nagayama nagayama commented Jun 25, 2017 •

Copy link
Copy Markdown
Contributor

I fixed the issue that reported on #680
This formats.link.value passed to value attribute of input. but the value attribute is not accepting null value.

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants