Repository navigation
Only expose the select function in registry selectors - #13889
Merged
youknowriad merged 1 commit intoFeb 15, 2019
Merged
Conversation
youknowriad
requested review from
aduth,
gziolo,
nerrad and
noisysocks
as code owners
February 15, 2019 10:12
nerrad
approved these changes
Feb 15, 2019
nerrad
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but a couple things:
- Need a
CHANGELOG.mdentry? - Should there be something in the README.md about this or are you holding off until it's been in use for a bit?
Contributor
Author
Probably not since it's the same as the previous one
This pattern of cross-stores dependencies is required but not sure yet if we should encourage it. It certainly deserves to be in an "Advanced" section in the data module docs. |
aduth
approved these changes
Feb 15, 2019
aduth
left a comment
Member
There was a problem hiding this comment.
Looks good 👍 I considered whether createRegistrySelector is still the best name to describe its purpose. I think it works well enough still.
youknowriad
deleted the
update/registry-selectors-to-only-expose-select
branch
February 15, 2019 15:08
This was referenced Feb 18, 2019
youknowriad
added a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
added a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the API of the registry selector to only receive "select" instead of "registry" to match
withSelectAPI.