Skip to content

Only expose the select function in registry selectors - #13889

Merged
youknowriad merged 1 commit into
masterfrom
update/registry-selectors-to-only-expose-select
Feb 15, 2019
Merged

youknowriad merged 1 commit into
masterfrom
update/registry-selectors-to-only-expose-select

Conversation

@youknowriad

Copy link
Copy Markdown
Contributor

This PR updates the API of the registry selector to only receive "select" instead of "registry" to match withSelect API.

@youknowriad youknowriad added the [Package] Data /packages/data label Feb 15, 2019
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
@youknowriad youknowriad self-assigned this Feb 15, 2019

@nerrad nerrad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a couple things:

  • Need a CHANGELOG.md entry?
  • Should there be something in the README.md about this or are you holding off until it's been in use for a bit?

@youknowriad

Copy link
Copy Markdown
Contributor Author

Need a CHANGELOG.md entry?

Probably not since it's the same as the previous one

Should there be something in the README.md about this or are you holding off until it's been in use for a bit?

This pattern of cross-stores dependencies is required but not sure yet if we should encourage it. It certainly deserves to be in an "Advanced" section in the data module docs.

@aduth aduth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I considered whether createRegistrySelector is still the best name to describe its purpose. I think it works well enough still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Data /packages/data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants