Skip to content

Improve scrolling in fullscreen mode, notably for Edge - #13327

Merged
youknowriad merged 1 commit into
masterfrom
fix/edge-fullscreen-scroll
Jan 18, 2019
Merged

youknowriad merged 1 commit into
masterfrom
fix/edge-fullscreen-scroll

Conversation

@jasmussen

Copy link
Copy Markdown
Contributor

In #12644, we changed the behavior of scrolling for the main content area slightly, to address issues with scrolling on small screens.

As part of that, there was one small issue that made it slightly harder to scroll this main content area, only when in fullscreen mode in Microsoft Edge. This PR fixes that.

Another side effect of that prior PR was that it unset some of the scrolling rules that prevented CSS bleed (when you scroll to the end of the Block Library and proceed to scroll the body content). This PR restores that.

Before:

before

After:

after

Also tested in IE:

ie11

In #12644, we changed the behavior of scrolling for the main content area slightly, to address issues with scrolling on small screens.

As part of that, there was one small issue that made it slightly harder to scroll this main content area, only when in fullscreen mode in Microsoft Edge. This PR fixes that.

Another side effect of that prior PR was that it unset some of the scrolling rules that prevented CSS bleed (when you scroll to the end of the Block Library and proceed to scroll the body content). This PR restores that.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Jan 15, 2019
@jasmussen jasmussen added this to the 5.0 (Gutenberg) milestone Jan 15, 2019
@jasmussen jasmussen self-assigned this Jan 15, 2019
@jasmussen
jasmussen requested a review from a team January 15, 2019 11:06
@aduth

aduth commented Jan 16, 2019

Copy link
Copy Markdown
Member

The issue described at #12644 (comment) is not resolved after these changes. Should we address separately or is it fundamentally tied to the specific direction we've taken with this implementation?

@jasmussen

Copy link
Copy Markdown
Contributor Author

The issue described at #12644 (comment) is not resolved after these changes. Should we address separately or is it fundamentally tied to the specific direction we've taken with this implementation?

Can you clarify this a little bit? I just tried this and it's working for me, but I may be misunderstanding your comment?

click below

@aduth

aduth commented Jan 18, 2019

Copy link
Copy Markdown
Member

Ah! I thought I'd tested on this branch. It's broken on master, but appears fixed here. A nice two-for-one then 😄

@aduth aduth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowriad
youknowriad merged commit 0c1f125 into master Jan 18, 2019
@youknowriad
youknowriad deleted the fix/edge-fullscreen-scroll branch January 18, 2019 15:58
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
In #12644, we changed the behavior of scrolling for the main content area slightly, to address issues with scrolling on small screens.

As part of that, there was one small issue that made it slightly harder to scroll this main content area, only when in fullscreen mode in Microsoft Edge. This PR fixes that.

Another side effect of that prior PR was that it unset some of the scrolling rules that prevented CSS bleed (when you scroll to the end of the Block Library and proceed to scroll the body content). This PR restores that.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
In #12644, we changed the behavior of scrolling for the main content area slightly, to address issues with scrolling on small screens.

As part of that, there was one small issue that made it slightly harder to scroll this main content area, only when in fullscreen mode in Microsoft Edge. This PR fixes that.

Another side effect of that prior PR was that it unset some of the scrolling rules that prevented CSS bleed (when you scroll to the end of the Block Library and proceed to scroll the body content). This PR restores that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants