Skip to content

Focus on RichText when selection changes - #12422

Merged
gziolo merged 2 commits into
masterfrom
rnmobile/rich-text-focus-on-selection
Nov 30, 2018
Merged

gziolo merged 2 commits into
masterfrom
rnmobile/rich-text-focus-on-selection

Conversation

@koke

@koke koke commented Nov 29, 2018 •

Copy link
Copy Markdown
Contributor

This solves an issue on iOS where RichText doesn’t get the focus when inserting or splitting into a new block.

To test see wordpress-mobile/gutenberg-mobile#298

@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 29, 2018
@koke
koke requested a review from mzorz November 29, 2018 14:46

@mzorz mzorz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and also fixes the same problem on Android.
LGTM :shipit:

@mzorz

mzorz commented Nov 29, 2018

Copy link
Copy Markdown
Contributor

I restarted 2 Travis jobs that were failing due to timeouts in tests, totally unrelated to these changes. Otherwise I think we can move forward and merge @koke 👍

@hypest

hypest commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

I've pinged @gziolo to merge this as it's failing on an unrelated e2e test.

…HEAD

* 'master' of https://github.com/WordPress/gutenberg:
  [RNmobile] Fix problems with undo/redo on Android (#12417)
  Add registry param to withDispatch component (#11851)
  Autocompleters: Consider block category (#12287)
  Only init TinyMCE once per instance (#12386)
  RichText: convert HTML formatting whitespace to spaces (#12166)
  Notices: Remove "files" block in package.json (#12438)
  Edit Post: Avoid rendering AdminNotices compatibility component (#12444)
  Correct the docs manifest (#12411)
@gziolo
gziolo merged commit bbba6f5 into master Nov 30, 2018
@gziolo
gziolo deleted the rnmobile/rich-text-focus-on-selection branch November 30, 2018 10:40
@gziolo gziolo added this to the 4.7 milestone Nov 30, 2018
@mtias mtias modified the milestones: 4.7, Mobile Alpha Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants