Repository navigation
Focus on RichText when selection changes - #12422
Merged
Merged
Conversation
mzorz
approved these changes
Nov 29, 2018
mzorz
left a comment
Contributor
There was a problem hiding this comment.
This looks good and also fixes the same problem on Android.
LGTM ![]()
Contributor
|
I restarted 2 Travis jobs that were failing due to timeouts in tests, totally unrelated to these changes. Otherwise I think we can move forward and merge @koke 👍 |
11 tasks done
Contributor
|
I've pinged @gziolo to merge this as it's failing on an unrelated e2e test. |
…HEAD * 'master' of https://github.com/WordPress/gutenberg: [RNmobile] Fix problems with undo/redo on Android (#12417) Add registry param to withDispatch component (#11851) Autocompleters: Consider block category (#12287) Only init TinyMCE once per instance (#12386) RichText: convert HTML formatting whitespace to spaces (#12166) Notices: Remove "files" block in package.json (#12438) Edit Post: Avoid rendering AdminNotices compatibility component (#12444) Correct the docs manifest (#12411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves an issue on iOS where RichText doesn’t get the focus when inserting or splitting into a new block.
To test see wordpress-mobile/gutenberg-mobile#298