Skip to content

Hide the image upload button on native until it's implemented - #12409

Merged
gziolo merged 1 commit into
masterfrom
rnmobile/hide-media-upload
Nov 30, 2018
Merged

gziolo merged 1 commit into
masterfrom
rnmobile/hide-media-upload

Conversation

@koke

@koke koke commented Nov 29, 2018

Copy link
Copy Markdown
Contributor

Since we can't do image uploads yet, let's just show the

Fixes wordpress-mobile/gutenberg-mobile#289

hide-image-upload

@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 29, 2018
@koke
koke requested a review from pinarol November 29, 2018 08:29

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works all OK 🎉

@hypest

hypest commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

I've pinged @gziolo to merge this as it's failing on an unrelated e2e test.

@gziolo
gziolo merged commit 05e5ea8 into master Nov 30, 2018
@gziolo
gziolo deleted the rnmobile/hide-media-upload branch November 30, 2018 10:28
@gziolo gziolo added this to the 4.7 milestone Nov 30, 2018
@mtias mtias modified the milestones: 4.7, Mobile Alpha Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants