Repository navigation
Conversation
Member
Author
|
Needs additional unit tests for |
Member
Author
|
Superseded by #12166. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11588. When creating a rich text value from text nodes, this branch reduces any sequence af new lines, tabs and spaces to one space. Afterwards, on a per line basis, it also trims leading and trailing whitespace, and reduces any sequence of spaces to one. This is needed because any sequence af new lines, tabs and spaces is used to format HTML, not as content. The browser will only displag it as one space, if it is used in between words.
Previously we were just removing any line breaks, which would normall still be displayed by the browser as a space.
How has this been tested?
Edit a paragraph as HTML. Remove a space and insert a line break (use ENTER). Edit visually. You should see a space where you inserted the line break. Edit as HTML. The line break should be replaced by a space.
Previously the line break would have been removed.
Screenshots
Types of changes
Checklist: