Repository navigation
Add hasInserterItems selector and improve getInserterItems selector performance - #11845
Merged
Merged
Conversation
tofumatt
approved these changes
Nov 14, 2018
tofumatt
left a comment
Member
There was a problem hiding this comment.
Explanation makes sense to me and I think the code reads fine. 👍
Member
youknowriad
force-pushed
the
try/improve-inserter-performance
branch
from
November 15, 2018 08:43
726d03a to
a4137cc
Compare
|
I built and ran this minute's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
getInserterItemsis called often (even if the inserter in not open) and its memoization is not performant.In this PR, I'm adding a new
hasInserterItemsselector which is more performant as it doesn't have to create inserter items and can return quickly after one insertable item is found.I also refactored a little bit the selectors to avoid using a memoized version of
canInsertBlockTypeas I think it's just not efficient to call memoized selectors inside other memoized selectors.I don't have the numbers as it's very hard to measure but I'd love your thoughts. I'm also considering dropping the memoization of these two selectors entirely because the cache is invalidated too often IMO.