You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Automated Testing: Unskip tests blocked by Enzyme support of React 16.3 #7005
Once the above issue is closed and Enzyme produces a new release introducing support for React.forwardRef, we should remove the workarounds introduced by #6527 .
Open questions:
What else do we use from React 16.3 that isn't supported by Enzyme that will need to be updated?
What components other than Button have tests which need to be updated?
This is how similar issues were fixed by @nerrad using React.TestUtils: #7835, #7834. We should go this route instead of waiting for enzyme to be upgraded.
Ya although its a pain, the more you work react-test-utils, and react-dom/test-utilities the less of a hassle it becomes. Definitely more reliable. It's kind of odd that the official react docs still suggest using enzyme.
Activity
gziolo commentedon May 29, 2018
I just wanted to add that all tests that we skip currently are blocked by Enzyme's upgrade.
gziolo commentedon Jul 13, 2018
This is how similar issues were fixed by @nerrad using
React.TestUtils: #7835, #7834. We should go this route instead of waiting forenzymeto be upgraded.nerrad commentedon Jul 13, 2018
Ya although its a pain, the more you work
react-test-utils, andreact-dom/test-utilitiesthe less of a hassle it becomes. Definitely more reliable. It's kind of odd that the official react docs still suggest using enzyme.nerrad commentedon Jul 13, 2018
Also worth noting that under the hood enzyme uses the various react test utilities.
aduth commentedon Jul 18, 2018
Can we make sure to cross-reference pull requests meant to be addressing (or partially addressing) this issue.
nerrad commentedon Jul 18, 2018
As far as I know there's only one skipped (unit) test now.
aduth commentedon Jul 18, 2018
Which pull requests are those? I'd like to keep record here for historical purposes.
nerrad commentedon Jul 18, 2018
The pulls I fixed skipped tests related to this were:
The pulls I converted away from enzyme (because they failed in #7557) are:
enzyme.mount(editor/components/url-input/test/button.js) #7786aduth commentedon Aug 9, 2018
We no longer use Enzyme.