You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Saving global styles: It is unclear what the number next to the checkbox is #30232
When saving global style changes a checkbox is displayed, and next to it, there is a number. The number has no context.
Without looking through all of the code I will assume that this is a unique ID for the global styles and the active theme,
but for most users, this number is not relevant, and it is confusing both to sighted users and screen reader users.
With a screen reader, the panel reads like this:
Save button
Close panel button
Global Styles button expanded heading level 2
5 check box checked
Step-by-step reproduction instructions
Activate a theme with support for full site editing and open the site editor.
Make changes to global styles, and save.
View the number in the save panel.
Expected behaviour
I expect the label to be relevant and describe what I am saving.
An initial thought is this should always use the "title". If a post doesn't have a title, should say "(untitled)". For global styles, it'd be nice to set a title on the post type object that holds the style info like "Custom Styles". cc @nosolosw
Activity
carolinan commentedon Mar 25, 2021
I found a similar issue if there is a post in the site editor, and the post has no post title.
I did not confirm but assumed this is the post ID.
mtias commentedon Mar 26, 2021
Yes, this definitely needs some improvements :)
cc @javierarce as part of looking at the multi-entity saving flow.
mtias commentedon Mar 26, 2021
An initial thought is this should always use the "title". If a post doesn't have a title, should say "(untitled)". For global styles, it'd be nice to set a title on the post type object that holds the style info like "Custom Styles". cc @nosolosw
oandregal commentedon Apr 6, 2021
#30521 fixes this.