Skip to content

Saving global styles: It is unclear what the number next to the checkbox is #30232

Closed

Description

@carolinan

Description

When saving global style changes a checkbox is displayed, and next to it, there is a number. The number has no context.

Without looking through all of the code I will assume that this is a unique ID for the global styles and the active theme,
but for most users, this number is not relevant, and it is confusing both to sighted users and screen reader users.

The save panel displays a heading and below that, a checkbox with the label "5"

With a screen reader, the panel reads like this:
Save button
Close panel button
Global Styles button expanded heading level 2
5 check box checked

Step-by-step reproduction instructions

  1. Activate a theme with support for full site editing and open the site editor.
  2. Make changes to global styles, and save.
  3. View the number in the save panel.

Expected behaviour

I expect the label to be relevant and describe what I am saving.

Actual behaviour

A number is displayed, and it has no context.

WordPress information

  • WordPress version: 5.7
  • Gutenberg version: current trunk at 6be973b
  • Are all plugins except Gutenberg deactivated? yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks, Empty theme

Device information

  • Device: Desktop
  • Operating system: Windows 10
  • Browser: Chrome Version 89.0.4389.90

Activity

  1. added
    Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.json
    on Mar 25, 2021
  2. carolinan commented on Mar 25, 2021

    @carolinan
    ContributorAuthor

    I found a similar issue if there is a post in the site editor, and the post has no post title.
    I did not confirm but assumed this is the post ID.

    if a post without a title is edited in the site editor, the post id(?) is showing

  3. mtias commented on Mar 26, 2021

    @mtias
    Member

    Yes, this definitely needs some improvements :)

    cc @javierarce as part of looking at the multi-entity saving flow.

  4. mtias commented on Mar 26, 2021

    @mtias
    Member

    An initial thought is this should always use the "title". If a post doesn't have a title, should say "(untitled)". For global styles, it'd be nice to set a title on the post type object that holds the style info like "Custom Styles". cc @nosolosw

  5. oandregal commented on Apr 6, 2021

    @oandregal
    Member

    #30521 fixes this.

  6. self-assigned this
    on Apr 6, 2021
  7. added
    [Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).
    and removed on Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Feature] SavingRelated to saving functionality[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions