Skip to content

Media library module dates filter doesn't fully display #2202

Closed

Description

@paaljoachim

As I click to add an image I notice that the All Dates dropdown is cropped.

screen shot 2017-08-04 at 01 26 36

Activity

  1. changed the title [-]Media library module crammed All Dates drop down ver 0.6[/-] [+]Media library module dates filter doesn't fully display[/+] on Aug 4, 2017
  2. added
    [Feature] MediaAnything that impacts the experience of managing media
    [Type] BugAn existing feature does not function as intended
    Good First IssueAn issue that's suitable for someone looking to contribute for the first time
    on Aug 4, 2017
  3. added this to the Beta 0.8.0 milestone on Aug 4, 2017
  4. karmatosed commented on Aug 4, 2017

    @karmatosed
    Member

    Good catch, I can replicate.

  5. removed this from the Beta 0.8.0 milestone on Aug 7, 2017
  6. mrxkon commented on Sep 7, 2017

    @mrxkon

    Hello there! Trying to help so I picked up an easy one to try the workflow.

    This could be 'easily' patched but the thing is that the css is actually coming from the media-views.css that resides in wp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.

    Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?

    If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed :D

  7. added
    [Type] WP Core TicketRequires an upstream change from WordPress. Core Trac ticket should be linked.
    on Dec 22, 2017
  8. nielslange commented on Dec 24, 2017

    @nielslange
    Contributor

    Related to #4034. Potential fix can be found there as well.

  9. added this to the milestone on Jan 25, 2018
  10. karmatosed commented on Apr 11, 2018

    @karmatosed
    Member

    Also worth noting: #6111

  11. modified the milestones: , on Apr 12, 2018
  12. 2 remaining items

  13. ianbelanger79 commented on Jul 30, 2018

    @ianbelanger79
    Contributor

    Hi All,

    I have a solution for this issue, but I would like to refer back to @mrxkon previous comment.

    Hello there! Trying to help so I picked up an easy one to try the workflow.

    This could be 'easily' patched but the thing is that the css is actually coming from the media-views.css that resides in wp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.

    Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?

    If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed

    Could I get some insight on this? Where should I put the CSS that is needed to fix this issue?

    Thanks

  14. self-assigned this
    on Aug 1, 2018
  15. brandonpayton commented on Aug 8, 2018

    @brandonpayton
    Member

    @mrxkon and @ianbelanger79, it looks like the best place to add a stopgap would be in a style.scss file that is a sibling and dependency of our MediaUpload component. If possible, it would be good to submit a patch to core for this issue and add a link to it with our Gutenberg fix, indicating the fix should be removed once it is patched in core.

  16. ajitbohra commented on Aug 9, 2018

    @ajitbohra
    Member
  17. youknowriad commented on Aug 9, 2018

    @youknowriad
    Contributor

    I'm closing as this is fixed in Gutenberg.

  18. added a commit that references this issue on May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Good First IssueAn issue that's suitable for someone looking to contribute for the first time[Feature] MediaAnything that impacts the experience of managing media[Type] BugAn existing feature does not function as intended[Type] WP Core TicketRequires an upstream change from WordPress. Core Trac ticket should be linked.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions