You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Media library module dates filter doesn't fully display #2202
changed the title [-]Media library module crammed All Dates drop down ver 0.6[/-][+]Media library module dates filter doesn't fully display[/+]on Aug 4, 2017
Hello there! Trying to help so I picked up an easy one to try the workflow.
This could be 'easily' patched but the thing is that the css is actually coming from the media-views.css that resides in wp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.
Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?
If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed :D
I have a solution for this issue, but I would like to refer back to @mrxkon previous comment.
Hello there! Trying to help so I picked up an easy one to try the workflow.
This could be 'easily' patched but the thing is that the css is actually coming from the media-views.css that resides in wp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.
Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?
If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed
Could I get some insight on this? Where should I put the CSS that is needed to fix this issue?
@mrxkon and @ianbelanger79, it looks like the best place to add a stopgap would be in a style.scss file that is a sibling and dependency of our MediaUpload component. If possible, it would be good to submit a patch to core for this issue and add a link to it with our Gutenberg fix, indicating the fix should be removed once it is patched in core.
Activity
[-]Media library module crammed All Dates drop down ver 0.6[/-][+]Media library module dates filter doesn't fully display[/+]karmatosed commentedon Aug 4, 2017
Good catch, I can replicate.
mrxkon commentedon Sep 7, 2017
Hello there! Trying to help so I picked up an easy one to try the workflow.
This could be 'easily' patched but the thing is that the css is actually coming from the
media-views.cssthat resides inwp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?
If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed :D
nielslange commentedon Dec 24, 2017
Related to #4034. Potential fix can be found there as well.
karmatosed commentedon Apr 11, 2018
Also worth noting: #6111
2 remaining items
ianbelanger79 commentedon Jul 30, 2018
Hi All,
I have a solution for this issue, but I would like to refer back to @mrxkon previous comment.
Could I get some insight on this? Where should I put the CSS that is needed to fix this issue?
Thanks
brandonpayton commentedon Aug 8, 2018
@mrxkon and @ianbelanger79, it looks like the best place to add a stopgap would be in a
style.scssfile that is a sibling and dependency of our MediaUpload component. If possible, it would be good to submit a patch to core for this issue and add a link to it with our Gutenberg fix, indicating the fix should be removed once it is patched in core.Expand date filter select box width (#8335)
ajitbohra commentedon Aug 9, 2018
Ticket/Patch
https://core.trac.wordpress.org/ticket/44760
youknowriad commentedon Aug 9, 2018
I'm closing as this is fixed in Gutenberg.
Media: Port date filter width fix from Gutenberg.
Media: Port date filter width fix from Gutenberg.
Media: Port date filter width fix from Gutenberg.
Media: Port date filter width fix from Gutenberg.
Media: Port date filter width fix from Gutenberg.
Media: Port date filter width fix from Gutenberg.
Media: Port date filter width fix from Gutenberg.
Merge pull request #2202 from wordpress-mobile/master-1.27.0-to-develop