Skip to content

Icon + up/down arrows for aligned/full width objects #110

Closed

Description

@ellatrix

In the current prototype, if the image is aligned right, the controls show on the other side and don't feel connected. Showing them on the right side might also be a bit odd if the left side is the "main" side.

Activity

  1. aduth commented on Feb 21, 2017

    @aduth
    Member

    Perhaps if they were given a docked (floating) toolbar effect similar to the block controls, it wouldn't seem so odd? Excuse the rough example:

    image

  2. folletto commented on Feb 21, 2017

    @folletto
    Contributor

    Interesting exploration... Maybe it could be a single bar, with a "head" that has arrows and icon, and the rest that has the options?

  3. ellatrix commented on Feb 21, 2017

    @ellatrix
    MemberAuthor

    Yeah that was my initial thought, but then it will require more clicks I guess. Move caret to block, press the icon, then arrows.

  4. ellatrix commented on Feb 21, 2017

    @ellatrix
    MemberAuthor

    screenshot 2017-02-21 19 02 07

  5. ellatrix commented on Feb 21, 2017

    @ellatrix
    MemberAuthor

    That's with old WP toolbar design, sorry, but you get the idea.

  6. jasmussen commented on Feb 21, 2017

    @jasmussen
    Contributor

    Hah, was just about to post something in the vein of Ella's above:

    screen shot 2017-02-21 at 19 03 48

    I'm not quite ready to go there, though — when it's docked like that it doesn't feel like "hover UI", and if we show it this way only for floated images, it's a different design for the same features. So I'm showing this not as a suggestion, but rather to keep the ideas flowing, in hopes the right solution will present itself.

  7. mtias commented on Feb 21, 2017

    @mtias
    Member

    See #53.

    I think we could try placing the controls to the right when floated right?

  8. ellatrix commented on Feb 21, 2017

    @ellatrix
    MemberAuthor

    Yeah, this was also my initial idea, see above comment. The downside is that the left side acts more or less as the main side for controls, so it can be a bit odd/disorienting to see controls on the other side just for right aligned objects.

  9. jasmussen commented on Feb 22, 2017

    @jasmussen
    Contributor

    Seems like it's worth trying them on the right side, for right aligned images, as it feels like a super easy win. But let's keep this ticket open (and ideas flowing), because the problem will likely reappear for full-bleed images.

  10. folletto commented on Feb 22, 2017

    @folletto
    Contributor

    I agree on @iseulde's point on having a stable main side of controls, so I had an idea that might be a bit counter intuitive but might just work: we always keep the control on that side, even if it gets indented. No flipping sides, no overlaying, nothing. In the end the control that is about to move is going to be "highlighted" in some way, so might just be obvious enough.

  11. ellatrix commented on Feb 22, 2017

    @ellatrix
    MemberAuthor

    I had two other thoughts on this:

    • Add a line that somehow makes it clear where the control is positioned in the vertical flow of the document. Personally I don't like this that much, but putting it out here anyway.
    • Have the arrows connected to the toolbar instead, as I've show in the mock-up, for all blocks. For aligned object blocks we don't really need the icon as the object is automatically selected (and has a toolbar) as soon as you click on it or move the caret to it. Non-object blocks cannot be aligned, so the icon is not an issue for these.
  12. mapk commented on Feb 24, 2017

    @mapk
    Contributor

    Have the arrows connected to the toolbar instead, as I've show in the mock-up, for all blocks.

    This solution seems to work well. It would also work in relation to mobile where currently the block-switcher gets lost off-screen. Example of lost block-switcher below.

    lost-block-switcher

  13. mapk commented on Feb 24, 2017

    @mapk
    Contributor

    Perhaps if they were given a docked (floating) toolbar effect similar to the block controls

    A floating element technically breaks out of the flow of markup, so maybe allowing the controls to break out of their normal state to match the element might be OK.

  14. jasmussen commented on Feb 27, 2017

    @jasmussen
    Contributor

    This solution seems to work well. It would also work in relation to mobile where currently the block-switcher gets lost off-screen. Example of lost block-switcher below.

    The UI prototype isn't mobile optimized, though, and though this mockup needs more love, the toolbars are docked:

  15. 5 remaining items

  16. ellatrix commented on Mar 7, 2017

    @ellatrix
    MemberAuthor

    Another idea would be to keep them in position and just overlay them on top of the image when there's no more space.

    We used to overlay images in core with controls but had to move away from that as we started using them for other objects, which can have their own controls inside the block (video/tweet links, buttons etc.) Not dismissing the idea, just something to keep in mind.

  17. mtias commented on Mar 7, 2017

    @mtias
    Member

    Not dismissing the idea, just something to keep in mind.

    Yes, I think many blocks would require clarity of these controls, so I propose we just align them vertically with the controls. Depending on how the API shapes up to be, this is something a block could declare.

  18. folletto commented on Mar 7, 2017

    @folletto
    Contributor

    Yes I agree, if we want to standardize for other full width items might not be a wise choice. What about instead just leaving a small gap instead of going full bleed? With the arrows being now without the selector dropdown they take less space so it might work.

  19. jasmussen commented on Mar 7, 2017

    @jasmussen
    Contributor

    What about instead just leaving a small gap instead of going full bleed?

    I'd think of this as a plan B. Full-bleed is kind of a bold look, and we want to convey that boldness in the UI too, and not "hold back". It isn't live preview, it's abstracted live preview, and it should probably give the same impression as when you see it on the site.

    Matias' idea of simply moving the arrows up above seems like an easy first step to try.

  20. added 2 commits that reference this issue on Mar 7, 2017
  21. added 2 commits that reference this issue on Mar 16, 2017
  22. changed the title [-]Icon + up/down arrows for aligned/full bleed objects[/-] [+]Icon + up/down arrows for aligned/full width objects[/+] on Mar 29, 2017
  23. added a commit that references this issue on Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions