Repository navigation
Maintain the Privacy Policy help notice location - #11
Merged
Merged
Conversation
Contributor
Member
Author
|
Tested this with the following conditions:
All scenarios correctly restored/preserved the notice location. |
azaozz
approved these changes
Nov 26, 2018
Member
Author
|
@youknowriad This can't be reverted until r43920 is reverted in WordPress Core. Even then, It will be tricky and I think it's best to leave this in here in some form for backward compatibility. Scenarios I think of are:
I have this on my list to follow up on with a new issue when it becomes clearer. |
|
Thanks for the clarification @desrosj just wanted to make sure it was not something we missed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the classic editor, the Privacy Policy help notice location in 4.9.x (directly under the post title with the
edit_form_after_titleaction hook) should be maintained.Related: WordPress/gutenberg#11999, WordPress/gutenberg#11604, Trac-45057.