Skip to content

Maintain the Privacy Policy help notice location - #11

Merged
azaozz merged 5 commits into
WordPress:masterfrom
desrosj:privacy-policy-help-notice
Nov 26, 2018
Merged

azaozz merged 5 commits into
WordPress:masterfrom
desrosj:privacy-policy-help-notice

Conversation

@desrosj

@desrosj desrosj commented Nov 19, 2018

Copy link
Copy Markdown
Member

When using the classic editor, the Privacy Policy help notice location in 4.9.x (directly under the post title with the edit_form_after_title action hook) should be maintained.

Related: WordPress/gutenberg#11999, WordPress/gutenberg#11604, Trac-45057.

@azaozz

azaozz commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

@desrosj updated this after all changes in beta-1. The remove_action/add_action have to run only when $settings['replace'] || self::is_classic( $post_id ). Could you see if it works as expected?

@desrosj

desrosj commented Nov 26, 2018

Copy link
Copy Markdown
Member Author

Tested this with the following conditions:

  • 5.0 RC1 with Classic Editor activated (no Gutenberg plugin).
  • 5.0 RC1 with both Classic Editor and Gutenberg activated.
  • WordPress 4.9.8 with Gutenberg plugin and Classic Editor active.
  • WordPress 4.9.8 with only the Classic Editor active (no Gutenberg plugin).

All scenarios correctly restored/preserved the notice location.

@azaozz
azaozz merged commit 7076276 into WordPress:master Nov 26, 2018
@desrosj
desrosj deleted the privacy-policy-help-notice branch November 26, 2018 20:21
@youknowriad

Copy link
Copy Markdown

I wonder if we need to revert this because the admin notices support was removed from RC2

@desrosj

desrosj commented Dec 4, 2018 •

Copy link
Copy Markdown
Member Author

@youknowriad This can't be reverted until r43920 is reverted in WordPress Core. Even then, It will be tricky and I think it's best to leave this in here in some form for backward compatibility.

Scenarios I think of are:

  • Reverted of r43920 in 5.0.1, and the user does not update the Classic Editor plugin
  • Revert this change in Classic Editor and user stays on a version of core less than the one with a revert of 443920.

I have this on my list to follow up on with a new issue when it becomes clearer.

@youknowriad

Copy link
Copy Markdown

Thanks for the clarification @desrosj just wanted to make sure it was not something we missed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants