New addon: Tab#1673
Conversation
z16
left a comment
z16
left a comment
There was a problem hiding this comment.
Mentioned a few minor things as well as a problem on my part which I'll fix later today. I'd like for both changes to go live at the same time.
| key_flags={} | ||
|
|
||
| --replace input tab. validated in Japanese keyboard. please let me know if problems occur with the English keyboard. | ||
| windower.register_event('keyboard',function(dik,flags,blocked) |
There was a problem hiding this comment.
This is not the right signature. It should be:
windower.register_event('keyboard',function(dik, pressed, flags, blocked)Where pressed is true if the key was pressed down and false if the key was released. Which also works better with what you're doing than calling it flags.
There was a problem hiding this comment.
wiki fixed :O
https://github.com/Windower/Lua/wiki/Events
There was a problem hiding this comment.
X key does not appear to be supported by flags. (I want to emulate the target filter of ffxiv)
| --replace input tab. validated in Japanese keyboard. please let me know if problems occur with the English keyboard. | ||
| windower.register_event('keyboard',function(dik,flags,blocked) | ||
| key_flags[dik] = flags | ||
| if flags and not windower.chat.is_open(true) then |
There was a problem hiding this comment.
This is my fault, is_open should not require an argument, but currently it does... I'll fix it later to not require the argument, so feel free to adjust it in the pull request already.
|
|
||
| --block error message. | ||
| windower.register_event('incoming text',function(original,modified,original_mode) | ||
| if original_mode == 123 and st then |
There was a problem hiding this comment.
When do you get this error? And why block it?
There was a problem hiding this comment.
When there is no <stnpc> target in the field of view of the player.
It was simply annoying for me :P
| _addon.author = 'from20020516' | ||
| _addon.version = '1.0' | ||
|
|
||
| key_flags={} |
There was a problem hiding this comment.
I would define the st variable here and default it to false.
|
changes done. thank you :) |
2 participants
Tab
English
<stnpc>or<stpc>. (X+Tab)<stnpc>by other players, use/ignorepet onand/ignoretrust on(in-game commands)日本語
<stnpc>または<stpc>(X+Tab)に置き換えます。<stnpc>に他プレイヤーのペットやフェイスを含めたくない場合、/ignorepet onまたは/ignorefaith on（ゲーム内コマンド）をご利用ください。