async.entity-tracking.enable -> async.entity-tracking#141
Closed
kalibrieren wants to merge 5 commits into
Closed
Conversation
windcolor-dev
requested changes
Jul 23, 2026
|
|
||
| private static void tracking() { | ||
| disableTracking = !getBoolean("settings.async.entity-tracking.enable", true); | ||
| tracking = getBoolean("settings.async.entity-tracking", true); |
Member
There was a problem hiding this comment.
Suggested change
| tracking = getBoolean("settings.async.entity-tracking", true); | |
| tracking = getBoolean("settings.async.entity-tracking.enable", true); |
This breaks YAML syntax and won't load correctly -
entity-tracking: true
threads: 4
Best to keep it like it is
Contributor
Author
There was a problem hiding this comment.
Oops didn't see the threads option!
Member
There was a problem hiding this comment.
Oops didn't see the
threadsoption!
No worries!
| } | ||
|
|
||
| public static boolean disableTracking; | ||
| public static boolean tracking; |
Member
There was a problem hiding this comment.
Maybe while you're at it refactor it to be clearer? (e.g. asyncEntityTracking or something like that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lil cleanup (should've already done this in #139)