Adds React 18 to peer deps ranges#140
Merged
Merged
Conversation
Owner
|
Thanks 👍 are we doing away with Husky? |
Contributor
Author
|
Ahhh! Well spotted, my mistake - brought the husky back home |
|
@Wildhoney Is the PR ready to be merged? Or should we keep using < react 18? |
|
Update: I created a fork to solve this problem https://www.npmjs.com/package/@hcfy/react-shadow I hope this PR will be merged soon, otherwise my project will report the following error when using npm to install dependencies: I've tried using --force or --legacy-peer-deps, but they both cause other problems, the biggest problem is that this will result in two versions of react in the project, one for 17 and the other for 18. |
Contributor
Author
|
@lmk123 existing tests passing; need repo author (@Wildhoney) to confirm it is ready and approve ✅ |
Owner
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended
peerDependenciesranges to include React 18Locked Travis Node JS version to 16 (LTS) so existing build/test scripts continue to work
Fix #137