Skip to content

Allow indexer reads during concurrent source writes#4090

Open
Widthdom wants to merge 1 commit into
mainfrom
fix-issue4078
Open

Allow indexer reads during concurrent source writes#4090
Widthdom wants to merge 1 commit into
mainfrom
fix-issue4078

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedNameFileContentLoader_Load_AllowsConcurrentWriterShare_Issue4078|FullyQualifiedNameTryComputeChecksum_FilePathAllowsConcurrentWriterShare_Issue4078" -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet format CodeIndex.sln --verify-no-changes
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --filter "FullyQualifiedNameFileContentLoader_Load_AllowsConcurrentWriterShare_Issue4078|FullyQualifiedNameTryComputeChecksum_FilePathAllowsConcurrentWriterShare_Issue4078"
  • dotnet build -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Full Release dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-build was stopped after unrelated performance guard failures; tracked separately in #4087.

Documentation and changelog

  • DEVELOPER_GUIDE.md
  • changelog.d/unreleased/4078.fixed.md

Review

  • Codex adversarial review: No blocking/actionable issues found.
  • codex exec review attempt was blocked by a Codex usage limit, so the local Codex review followed .codex/workflows/adversarial-review.md.

Follow-up candidates

Fixes #4078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit file open, stream, and directory creation policy for bounds, sharing, and permissions

1 participant