[codex] Centralize process launch policy for workers#4088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessLaunchPolicy.Launch-Site Classification
GitHelperuses trusted git resolution, no shell, git-specific environment allowlist, bounded capture, and timeout/cancellation.ProgramRunneruses trusted bash resolution, no shell, installer environment allowlist, timeout/cancellation, and bounded suppressed output capture.SymbolExtractionWorkeruses isolated worker defaults and shared worker command/protocol arguments.PostExtractionHookCallbackWorkeruses isolated worker defaults, hook assembly/type arguments, and shared worker command/protocol arguments.IsolatedWorkerProcessLaunchercentralizes worker stdio/UTF-8/no-shell defaults and dotnet host preparation.SubprocessEnvironmentPolicyowns git, installer, and isolated-worker environment allowlists.ProcessLaunchPolicyowns no-shell start-info defaults and worker protocol argument construction.Validation
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ProcessLaunchPolicyTests|FullyQualifiedName~SymbolExtractionWorker_StartInfo|FullyQualifiedName~PostExtractionHookCallbackWorker_StartInfo|FullyQualifiedName~IsolatedWorkers_StartInfo"dotnet run --project tools/CodeIndex.Changelog -- checkdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet builddotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll search --recipe risky-code/process-start-info --path src/ --exclude-tests --count-by file --limit 80Documentation and Changelog
DEVELOPER_GUIDE.mdin English and Japanese.changelog.d/unreleased/4075.security.md.Review
Follow-up Candidates
Fixes #4075