Skip to content

Replace AddWithValue in symbol lookups#4084

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue4057
Jun 28, 2026
Merged

Replace AddWithValue in symbol lookups#4084
Widthdom merged 1 commit into
mainfrom
fix-issue4057

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Replaced the remaining GetSymbolsAtLine AddWithValue calls with SqliteCommandPolicy.Add typed parameter binding.
  • Added AnalyzeFileLine coverage for line lookup with kind and lang filters.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~AnalyzeFileLine_WithKindAndLanguageFilters_ReturnsSymbolAtLine_Issue4057"
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll audit dotnet-risk-patterns --path src/ --json (sqlite-addwithvalue count: 0)
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet format CodeIndex.sln --verify-no-changes --include src/CodeIndex/Database/DbSymbolReader.cs tests/CodeIndex.Tests/DbReaderTests.cs --no-restore
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~Extract_JavaScriptLargeExportedObjectLiteralProperties_CompletesWithinPracticalBudget" -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json

Full-suite note: dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --settings tests/CodeIndex.Tests/CodeIndex.Tests.runsettings --blame-crash --blame-hang --blame-hang-timeout 5m -p:UseSharedCompilation=false was attempted under concurrent local indexer load and hit an unrelated practical-budget timeout in Extract_JavaScriptLargeExportedObjectLiteralProperties_CompletesWithinPracticalBudget; the same test passed/skipped as expected when rerun directly.

Documentation / Changelog

  • Added changelog fragment: changelog.d/unreleased/4057.fixed.md.
  • No guide or user documentation changes were needed for this internal binding-policy fix.

Follow-up Candidates

None.

Fixes #4057

@Widthdom Widthdom marked this pull request as ready for review June 28, 2026 02:59
@Widthdom Widthdom merged commit 8f3ec56 into main Jun 28, 2026
10 checks passed
@Widthdom Widthdom deleted the fix-issue4057 branch June 28, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace remaining AddWithValue usage in symbol lookups

1 participant