Integration test for Multisig delegated vLEI issuance (QVI, LE, ECR) - #207
Merged
Merged
Conversation
nkongsuwan
marked this pull request as draft
January 26, 2024 13:58
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #207 +/- ##
============================================
Coverage 82.85% 82.85%
============================================
Files 47 47
Lines 4200 4200
Branches 1046 1046
============================================
Hits 3480 3480
Misses 691 691
Partials 29 29 ☔ View full report in Codecov by Sentry. |
nkongsuwan
force-pushed
the
multisig-vlei-test
branch
3 times, most recently
from
February 18, 2024 12:52
fe67ee6 to
c4ff292
Compare
nkongsuwan
force-pushed
the
multisig-vlei-test
branch
2 times, most recently
from
February 18, 2024 14:41
947f16f to
0468df0
Compare
nkongsuwan
marked this pull request as ready for review
February 20, 2024 13:13
Contributor
Author
|
This PR is completed, but it is based on the recent change in PR #222, which hasn't yet been merged. |
|
Why not use |
Member
|
PR #222 has been merged so a rebase here should get this build working. |
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
nkongsuwan
force-pushed
the
multisig-vlei-test
branch
from
March 29, 2024 11:10
ef039b0 to
09030c9
Compare
lenkan
self-requested a review
April 4, 2024 14:51
lenkan
approved these changes
Apr 4, 2024
lenkan
left a comment
Collaborator
There was a problem hiding this comment.
This LGTM. Only thing is that test time increases significantly, I suppose there is now some overlap in this test and the multisig.test.ts file that can be addressed later.
daviddm
pushed a commit
to daviddm/signify-ts
that referenced
this pull request
May 8, 2024
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an integration test for multi-signature delegated issuance of QVI, LE, and ECR vLEI credentials:
[Edit 18 Feb]: the three problems below seem to have been resolved.
Currently, there are two problems, one major and one minor:
client.registries().list(). This is related to the issues in Signify-TS and KERIA, Intermittent KERIA Internal Server Errors (HTTP 500) when listing registries. keria#147, Transient error with usingclient.registries().list(name)keria#177, and add test triggering credential revocation crash #202.