Repository navigation
fix: stop scoring two checks that fire on real browsers - #130
Merged
Merged
Conversation
The console-attach probe fired in every real Chrome and Safari session measured, with no DevTools open and extensions disabled. The SF Pro check flagged every Firefox on macOS: browsers do not expose SF Pro by name, and only Firefox's frozen "10.15" UA slipped past the version exclusion. Co-Authored-By: Claude <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cport1
added a commit
that referenced
this pull request
Oct 14, 2026
The console-attach probe fired in every real Chrome and Safari session measured, with no DevTools open and extensions disabled. The SF Pro check flagged every Firefox on macOS: browsers do not expose SF Pro by name, and only Firefox's frozen "10.15" UA slipped past the version exclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two detections fire for ordinary visitors on real browsers:
cdpRuntime.consoleAttached, cdp 0.6): fired in every real Chrome and Safari session measured, with DevTools closed and extensions disabled. Still collected by the client, no longer scored.hasSFProis false on every Mac. Chrome and Safari were skipped by the10_15exclusion; Firefox's UA says10.15, so every Firefox on macOS was flagged. Removed. Mac font coherence is still covered byhasMenloin input forensics.Applied to Go, Node and Python. Unit tests and cross-server conformance pass on all three.