Skip to content

ci: drop housekeeping reviewer-request for native team assignment - #311

Merged
EricAndrechek merged 1 commit into
mainfrom
drop-housekeeping-reviewer-assign
Jun 10, 2026
Merged

ci: drop housekeeping reviewer-request for native team assignment#311
EricAndrechek merged 1 commit into
mainfrom
drop-housekeeping-reviewer-assign

Conversation

@EricAndrechek

Copy link
Copy Markdown
Member

Summary

Now that the wavehouse-admins team has repo access and code-review assignment (load-balanced) configured, reviewer routing is fully GitHub-native — so this removes the now-redundant housekeeping.yml reviewer machinery.

The native flow: the required_reviewers ruleset rule requests the @Wave-RF/wavehouse-admins team on every PR → the team's code-review assignment auto-assigns + load-balances a specific member → their approval satisfies the rule.

Changes

  • housekeeping.yml — remove the pick-reviewer step, the Assign + request review step (which used the composite), and the Load board config step. It now does only: path-labeling + PR-title-lint + the title-fail sticky comment.
  • Delete .github/actions/assign-and-request-review/ — the composite's only remaining consumer (after dependabot-automerge.yml was removed in ci: replace admin-approval workflow with native required_reviewers #310).
  • board-config.env — drop ADMINS (its last consumer gone), killing the team-membership-vs-ADMINS drift; the file now carries only Task Board IDs for triage.yml.
  • Doc-syncAGENTS.md, docs/src/content/docs/development.md, docs/src/content/docs/claude-code.md, CHANGELOG.md.

Net

−229 lines. Bonus: removing the board-config-load step also clears a pre-existing SC2086 actionlint warning on that line.

Testing

make ci green; both pre-push reviewers (pre-push-reviewer, docs-reviewer) → ship_it. The native reviewer-assignment behavior validates on the next non-bypass PR (this PR still triggers main's housekeeping via pull_request_target until merged).

🤖 Generated with Claude Code

The wavehouse-admins team now has repo access and code-review
assignment (load-balanced) configured, so GitHub handles reviewer
routing natively: the required_reviewers ruleset rule requests the team
on every PR and the team auto-assigns + load-balances a member. That
makes housekeeping's manual reviewer pick/request redundant.

- housekeeping.yml: remove the pick-reviewer + assign-and-request-review
  steps (and the board-config load); it now only labels + lints the title.
- Delete the now-unused .github/actions/assign-and-request-review composite.
- board-config.env: drop ADMINS (its last consumer gone) — kills the
  team-vs-ADMINS drift; the file now only carries Task Board IDs.
- Doc-sync: AGENTS.md (review-tooling table, reviewer-assignment rule,
  governance files), development.md, claude-code.md.

Side benefit: removing the board-config-load step also clears the
pre-existing SC2086 actionlint warning on that line.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@EricAndrechek, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 37 minutes and 14 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a10af1a6-f61f-4fd2-9506-c27f2667ba97

📥 Commits

Reviewing files that changed from the base of the PR and between e816de6 and 3ecf06d.

📒 Files selected for processing (7)
  • .github/actions/assign-and-request-review/action.yml
  • .github/board-config.env
  • .github/workflows/housekeeping.yml
  • AGENTS.md
  • CHANGELOG.md
  • docs/src/content/docs/claude-code.md
  • docs/src/content/docs/development.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-housekeeping-reviewer-assign
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch drop-housekeeping-reviewer-assign

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code area/docs Documentation, site/, README area/infra CI, build, deploy, Docker, release labels Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

📚 Docs preview is livehttps://ee427e07-wavehouse-docs.wave-rf.workers.dev

  • Commit3ecf06d: ci: drop housekeeping reviewer-request for native team assignment
  • Author@EricAndrechek, Claude Opus 4.8 (1M context)
  • Committed — 2026-06-09 21:09 (UTC-04:00)
  • Deployed — 2026-06-09 21:33 EDT

@EricAndrechek
EricAndrechek marked this pull request as ready for review June 10, 2026 01:28
@EricAndrechek
EricAndrechek requested review from a team and taitelee June 10, 2026 01:28
@EricAndrechek
EricAndrechek merged commit a094132 into main Jun 10, 2026
11 checks passed
@EricAndrechek
EricAndrechek deleted the drop-housekeeping-reviewer-assign branch June 10, 2026 01:34
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WaveHouse Task Board Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation, site/, README area/infra CI, build, deploy, Docker, release documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants