deps: bump github.com/nats-io/nats.go from 1.51.0 to 1.52.0 in the go-deps group - #128
Closed
dependabot[bot] wants to merge 1 commit into
Closed
deps: bump github.com/nats-io/nats.go from 1.51.0 to 1.52.0 in the go-deps group#128dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the go-deps group with 1 update: [github.com/nats-io/nats.go](https://github.com/nats-io/nats.go). Updates `github.com/nats-io/nats.go` from 1.51.0 to 1.52.0 - [Release notes](https://github.com/nats-io/nats.go/releases) - [Commits](nats-io/nats.go@v1.51.0...v1.52.0) --- updated-dependencies: - dependency-name: github.com/nats-io/nats.go dependency-version: 1.52.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
github-actions
Bot
added
area/infra
PR title doesn't match the required formatGot: Expected format: Allowed types: The optional Examples:
This check is required by the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
2 tasks
Contributor
Author
|
Looks like github.com/nats-io/nats.go is updatable in another way, so this is no longer needed. |
auto-merge was automatically disabled
May 13, 2026 15:19
Pull request was closed
4 tasks
EricAndrechek
added a commit
that referenced
this pull request
May 13, 2026
## Summary Closes #130 (the title-length and admin-bypass halves; the go-mod-tidy half is intentionally deferred — manual `make tidy && go mod tidy` after a failing CI run is the accepted workflow). `admin-approval.yml` previously short-circuited to `success` for **all** Dependabot PRs, on the assumption that "no bot approves itself + no auto-merge enabled = major bumps will sit." That assumption broke once CodeRabbit started auto-approving Dependabot PRs after autofixes. PR #127 (major-bump: TypeScript 5→6, Astro 5→6, etc.) reached `mergeStateStatus: CLEAN, reviewDecision: APPROVED` — one click from main — with no admin review: - CodeRabbit's `APPROVED` review satisfied the ruleset's `required_approving_review_count: 1` - The unconditional bypass posted `Admin approval: success` - CI was green ## Changes ### `admin-approval.yml` - New `Fetch Dependabot metadata` step at the top, gated on Dependabot author (`continue-on-error: true` so a metadata fetch failure on a Dependabot PR fail-safes to "no bypass" rather than erroring the workflow). - Bypass logic now only fires when `update-type` is `version-update:semver-patch` or `version-update:semver-minor`. Majors, unknown types, and empty `UPDATE_TYPE` (metadata fetch failed) fall through to the same admin-review evaluation as human PRs. - Updated header comment + inline comments to explain the new model and reference #130 / #127 as the trigger. ### `housekeeping.yml` - PR title length check (72-char cap) now exempts Dependabot. Format regex is still enforced; Dependabot's grouped-update titles already use lowercase `deps:` / `ci:` / `docs:` prefixes, so they pass naturally. Fixes the half of #130 about title-length blocking grouped bumps (e.g., #128's 80-char title). ### `AGENTS.md` - Three passages updated to reflect "Dependabot patch/minor PRs bypass; majors require admin review same as human PRs." - New note in the Dependabot section explaining that `required_approving_review_count: 0` in the ruleset is intentional — the `Admin approval` status check is the single admin-review gate, so any bot's `APPROVED` review is no longer load-bearing. ## Ruleset change (manual, after merge) The workflow changes alone close the security hole (majors now post `Admin approval: pending`, blocking merge). The ruleset count-rule change is **defense-in-depth** — without it, CodeRabbit's approval can still satisfy `count: 1` on a major bump even though the `Admin approval` status is now correctly pending. Easiest path is the GitHub UI: **Settings → Rules → main branch protection (ruleset 15353356) → Require a pull request before merging → set "Required approving reviews" to 0**. All other rule params should stay unchanged — especially `dismiss_stale_reviews_on_push: true`, `strict_required_status_checks_policy: true`, the required status checks list, and the admin bypass actor. (`gh api` works too but requires fetching the current ruleset, modifying the `required_approving_review_count` field inside the `pull_request` rule, and PUT-ing the full payload back. The UI is one click.) ## Behavior matrix after this PR (workflow only, before ruleset change) | PR type | Title cap | Admin approval status | Count rule | Merges? | |---|---|---|---|---| | Dependabot patch | exempt | success (bypassed) | bot self-approval | yes, auto | | Dependabot minor | exempt | success (bypassed) | bot self-approval | yes, auto | | Dependabot major (no admin) | exempt | **pending** | CodeRabbit may satisfy | **blocked** by status | | Dependabot major (admin approved) | exempt | success | yes | yes, manual | | Human PR (no admin) | 72-char | pending | — | blocked | | Human PR (admin approved) | 72-char | success | yes | yes, manual | After the ruleset change (count → 0), the third row stays blocked regardless of CodeRabbit's approval state, closing the defense-in-depth gap. ## Test plan - [ ] Once merged, next Monday's Dependabot patch/minor bumps auto-merge as before (no regression on the auto-merge path). - [ ] Open a draft test PR with an 80-char title to verify the title-cap exemption only applies to Dependabot (i.e., human long-title still fails). - [ ] On the next major-version Dependabot PR: confirm `Admin approval` status posts `pending` and the PR is blocked until an admin approves. - [ ] Apply ruleset change (`count: 0`) and verify the same major PR remains blocked even if CodeRabbit's review is `APPROVED`. ## Notes - I considered also touching `housekeeping.yml`'s reviewer-assign skip-for-Dependabot logic, but it's still correct: `dependabot-automerge.yml` already assigns both admins on majors, so housekeeping's skip avoids a double-request. Left as-is. - The CodeRabbit dashboard switch (from `APPROVED` to `COMMENTED`) is intentionally NOT part of this PR — it's a separate dashboard setting, not a repo change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Refined automated dependency update workflows with improved approval handling for different update types. * Enhanced pull request validation to better support automated dependency changes while maintaining code quality standards. * Updated development governance documentation with clearer guidelines and more explicit rules for approval processes and automation. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/Wave-RF/WaveHouse/pull/134) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
](https://app.coderabbit.ai/change-stack/Wave-RF/WaveHouse/pull/134){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the go-deps group with 1 update: github.com/nats-io/nats.go.
Updates
github.com/nats-io/nats.gofrom 1.51.0 to 1.52.0Release notes
Sourced from github.com/nats-io/nats.go's releases.
Commits
e9f2a36Release v1.52.0 (#2074)609274f[FIXED] Subscription.StatusChanged channel closure on Closed Subscription (#2...f7cde74[IMPROVED] Use latest release build for badge in README (#2064)c7476ea[IMPROVED] Reject empty consumer info in CONSUMER.RESET response (#2072)8fde36f[ADDED] ResetConsumer JetStream API (#2069)dcfd0fc[ADDED] StreamSource.Consumer config field and AckFlowControlPolicy (#2070)7a28503[ADDED] Publish options and consts for message scheduling (#2051)6c91a51[ADDED] AllowBatchPublish stream config field (#2052)a614d0b[FIXED] Flaky JS cluster tests due to race in setupJSClusterWithSize (#2062)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions