Skip to content

Bump nbgv from 3.9.50 to 3.10.91 - #338

Merged
amis92 merged 1 commit into
mainfrom
dependabot/nuget/dot-config/nbgv-3.10.91
Jul 31, 2026
Merged

Bump nbgv from 3.9.50 to 3.10.91#338
amis92 merged 1 commit into
mainfrom
dependabot/nuget/dot-config/nbgv-3.10.91

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 31, 2026

Copy link
Copy Markdown
Contributor

Updated nbgv from 3.9.50 to 3.10.91.

Release notes

Sourced from nbgv's releases.

3.10.91

What's Changed

Full Changelog: dotnet/Nerdbank.GitVersioning@v3.10.85...v3.10.91

3.10.85

What's Changed

Full Changelog: dotnet/Nerdbank.GitVersioning@v3.10.70...v3.10.85

3.10.70

What's Changed

Fixes

Enhancements

Full Changelog: dotnet/Nerdbank.GitVersioning@v3.9.50...v3.10.70

3.10.44-alpha

What's Changed

Fixes

Enhancements

Dependency updates

Full Changelog: dotnet/Nerdbank.GitVersioning@v3.10.8-alpha...v3.10.44-alpha

3.10.8-alpha

What's Changed

Full Changelog: dotnet/Nerdbank.GitVersioning@v3.9.50...v3.10.8-alpha

Commits viewable in compare view.

@dependabot dependabot Bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Jul 31, 2026
@dependabot
dependabot Bot requested a review from amis92 as a code owner July 31, 2026 06:20
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Jul 31, 2026
amis92 added a commit that referenced this pull request Jul 31, 2026
CI fails on every Dependabot pull request at the first step:

    Error: The 'private-key' input must be set to a non-empty string.

GitHub does not expose regular Actions secrets to Dependabot-triggered runs —
they live in a separate Dependabot secrets store — so
`secrets.WARHUB_BOT_PRIVATE_KEY` is empty and `actions/create-github-app-token`
fails before anything is checked out. #338 is the first PR to hit it.

The token was there so `submodules: true` could reach `battlescribe-spec` back
when that repository was private. It is public now and clones anonymously, so
the default `GITHUB_TOKEN` is sufficient and the whole step is dead weight that
only breaks things.

Removes the step and the `token:` input, keeping `submodules: true`. A comment
records why it must not come back.

`publish.yml` keeps its App token — it runs on `workflow_dispatch`, where
secrets are available, so it is not affected. It is equally redundant now and
could be simplified separately.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
amis92 added a commit that referenced this pull request Jul 31, 2026
CI fails on every Dependabot pull request at the first step:

    Error: The 'private-key' input must be set to a non-empty string.

GitHub does not expose regular Actions secrets to Dependabot-triggered runs —
they live in a separate Dependabot secrets store — so
`secrets.WARHUB_BOT_PRIVATE_KEY` is empty and `actions/create-github-app-token`
fails before anything is checked out. #338 is the first PR to hit it.

The token was there so `submodules: true` could reach `battlescribe-spec` back
when that repository was private. It is public now and clones anonymously, so
the default `GITHUB_TOKEN` is sufficient and the whole step is dead weight that
only breaks things.

Removes the step and the `token:` input, keeping `submodules: true`. A comment
records why it must not come back.

`publish.yml` keeps its App token — it runs on `workflow_dispatch`, where
secrets are available, so it is not affected. It is equally redundant now and
could be simplified separately.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@amis92

amis92 commented Jul 31, 2026

Copy link
Copy Markdown
Member

@dependabot rebase

CI was failing here for an unrelated reason: the Generate GitHub App token step could not read secrets.WARHUB_BOT_PRIVATE_KEY, because Actions secrets are not exposed to Dependabot-triggered runs. That step has been removed in #341battlescribe-spec is public now, so the default token clones the submodule fine.

Rebasing onto current main should pick that up and go green. This bump is wanted: it brings the nbgv CLI in .config/dotnet-tools.json in line with the Nerdbank.GitVersioning package version already bumped to 3.10.91 in #327.

---
updated-dependencies:
- dependency-name: nbgv
  dependency-version: 3.10.91
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/nuget/dot-config/nbgv-3.10.91 branch from aaebfb6 to c0ff406 Compare July 31, 2026 06:39
@amis92
amis92 merged commit d66c97c into main Jul 31, 2026
2 checks passed
@amis92
amis92 deleted the dependabot/nuget/dot-config/nbgv-3.10.91 branch July 31, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .net code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant