fix(macos): respect system language for UI translations - #87
Open
xieyuanbin1 wants to merge 1 commit into
Open
xieyuanbin1 wants to merge 1 commit into
xieyuanbin1 wants to merge 1 commit into
Conversation
The app bundle ships UI translations as embedded Qt .qm resources and declares no .lproj localizations, so macOS resolved the process locale language to the development region (English) no matter which language the user's system was set to. Qt then reported an en-XX locale and L10nLoader only considered the leading "en" entry of ui-languages, loading the empty wsjtx_en.qm stub - every non-English user saw an English UI on macOS. Add CFBundleAllowMixedLocalizations so macOS resolves the process locale from the user's language settings instead of collapsing it to the development region. Verified end-to-end on the real app bundle (per-app AppleLocale/ AppleLanguages simulation): zh_CN/zh_TW/ja/ru/es/it/da/ca each load their .qm, en_GB loads wsjtx_en_GB.qm, en_US stays English, and de correctly finds no wsjtx_de and falls back. From BI9BWT
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app bundle ships UI translations as embedded Qt .qm resources and declares no .lproj localizations, so macOS resolved the process locale language to the development region (English) no matter which language the user's system was set to. Qt then reported an en-XX locale and L10nLoader only considered the leading "en" entry of ui-languages, loading the empty wsjtx_en.qm stub - every non-English user saw an English UI on macOS.
Add CFBundleAllowMixedLocalizations so macOS resolves the process locale from the user's language settings instead of collapsing it to the development region.
Verified end-to-end on the real app bundle (per-app AppleLocale/ AppleLanguages simulation): zh_CN/zh_TW/ja/ru/es/it/da/ca each load their .qm, en_GB loads wsjtx_en_GB.qm, en_US stays English, and de correctly finds no wsjtx_de and falls back.
From BI9BWT