Skip to content

Added optional unit parameter to kinetics#25

Open
uliw wants to merge 1 commit intoVitens:masterfrom
uliw:master
Open

Added optional unit parameter to kinetics#25
uliw wants to merge 1 commit intoVitens:masterfrom
uliw:master

Conversation

@uliw
Copy link
Copy Markdown

@uliw uliw commented Dec 8, 2022

It seems that the kinetic method always assumes that the rates returned by the rate_function are in mmol.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2022

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.50%. Comparing base (d6f94d8) to head (08f44ff).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
phreeqpython/solution.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files           7        7           
  Lines         698      698           
=======================================
  Hits          527      527           
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant