Skip to content

fix(capture-area): fix scaling#64

Merged
Claiyc merged 2 commits into
mainfrom
fix/63-ca-scaling
Dec 11, 2022
Merged

fix(capture-area): fix scaling#64
Claiyc merged 2 commits into
mainfrom
fix/63-ca-scaling

Conversation

@Claiyc

@Claiyc Claiyc commented Dec 11, 2022

Copy link
Copy Markdown
Member

PR description

Describe your changes in detail here
Fix scaling of capture area so scale on preview will be correctly translated to scale of stream.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR
fixes #63

@Claiyc Claiyc added Phase: Elaboration RUP: Implementation improvement Some layout / structure / performance optimization labels Dec 11, 2022
@Claiyc
Claiyc requested a review from tonoizer December 11, 2022 23:00
@Claiyc Claiyc self-assigned this Dec 11, 2022

@tonoizer tonoizer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@Claiyc
Claiyc merged commit 078e82d into main Dec 11, 2022
@Claiyc
Claiyc deleted the fix/63-ca-scaling branch December 11, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Some layout / structure / performance optimization Phase: Construction RUP: Implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scale capture area width to window(mediastream) width

2 participants