Skip to content

feat: Adapt to MVP mock up#59

Merged
tonoizer merged 26 commits into
mainfrom
feat/52-adapt-to-mvp-mock-up
Dec 11, 2022
Merged

feat: Adapt to MVP mock up#59
tonoizer merged 26 commits into
mainfrom
feat/52-adapt-to-mvp-mock-up

Conversation

@tonoizer

@tonoizer tonoizer commented Dec 11, 2022 •
edited by Claiyc
Loading

Copy link
Copy Markdown
Contributor

PR description

Describe your changes in detail here

The UI has be updated to the newest design with the Vuetify component and has the proper spacing like in the prototype design. So that our MVP has the proper user interface.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

fixes #52

Kevin Beier added 21 commits December 8, 2022 22:36
added margin between both panels
bb8249a 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
properly used the loading prop for sources
5a71ea7 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
moved to composable folders
13c4bae 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
updated rerendere imports
ed551c6 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
composable to check the running status
bfc8666 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
commented
2a3a61f 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
updating run view
5bdbab3 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
removed unused import
5836aeb 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
small change
bb65488 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
reimplementation of the sources tabs
e5e1445 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
initial try for reimplementation
31dd822 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
margin changes
0055252 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
applied proper new styling
f9c35a8 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
applying new design
9208b82 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
new design for capture area values
e206d72 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
adjust style of draggable
9b74bba 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
fixed miss match of regex inputs
3d3d574 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
type changes and ID to ca
a78c849 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
ordering the options
9c931ba 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
renaming and centering
19b3279 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
added simple log item
ecd4278 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
@tonoizer
tonoizer requested a review from Claiyc December 11, 2022 13:48
@tonoizer tonoizer self-assigned this Dec 11, 2022
@tonoizer tonoizer added Phase: Elaboration RUP: Implementation improvement Some layout / structure / performance optimization labels Dec 11, 2022
@tonoizer
tonoizer requested a review from roman533 December 11, 2022 13:56
roman533
roman533 previously approved these changes Dec 11, 2022
View reviewed changes

@roman533 roman533 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, looks good

removed save button
7c3f26b 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
Claiyc
Claiyc requested changes Dec 11, 2022
View reviewed changes

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall

Comment thread src/components/capture-area/AfterConstraintRegex.vue
Comment thread src/components/capture-area/BeforeConstraintRegex.vue Outdated
@Claiyc Claiyc linked an issue Dec 11, 2022 that may be closed by this pull request
Adapt design to MVP mockup #52
Closed
12 tasks
Kevin Beier added 2 commits December 11, 2022 16:11
reusable regexinput component
a070a6a 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
removed unused components
bf1de04 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
@tonoizer
tonoizer requested review from Claiyc and roman533 and removed request for roman533 December 11, 2022 15:12
Claiyc
Claiyc previously approved these changes Dec 11, 2022
View reviewed changes

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

extracted loging output into component
c2ca279 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
removed useless import
d93ba33 
Signed-off-by: Kevin Beier <beierkevin2002@outlook.com>
Claiyc
Claiyc approved these changes Dec 11, 2022
View reviewed changes

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now

@tonoizer
tonoizer merged commit bd46b08 into main Dec 11, 2022
@tonoizer
tonoizer deleted the feat/52-adapt-to-mvp-mock-up branch December 11, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Claiyc Claiyc Claiyc approved these changes
@roman533 roman533 roman533 left review comments

Assignees

@tonoizer tonoizer

Labels

improvement Some layout / structure / performance optimization Phase: Construction RUP: Implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt design to MVP mockup

3 participants

@tonoizer @Claiyc @roman533