Skip to content

feat: tesseract implementation#58

Merged
Claiyc merged 3 commits into
mainfrom
feat/23-tesseract
Dec 11, 2022
Merged

feat: tesseract implementation#58
Claiyc merged 3 commits into
mainfrom
feat/23-tesseract

Conversation

@Claiyc

@Claiyc Claiyc commented Dec 11, 2022

Copy link
Copy Markdown
Member

PR description

Describe your changes in detail here
Once merged, this will add image-to-text translation using tesseract.js (not using regex recognition yet).
This will take capture areas into consideration (only extract text in capture areas)

As of now this will just print the recognized text into the run-view.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR
fixes #23

@Claiyc

Claiyc commented Dec 11, 2022

Copy link
Copy Markdown
Member Author

First part of implementation. Currently works as "call once, run once" -> should of course work as background-loop in the end. Mapping of capture areas to actual stream is not correct yet.
As of now it's quite the ugly chaining of async functions.. Will probably have to iterate on that.

@tonoizer tonoizer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all, the implementation looks quite good, but we will see how good this works together with the regex matcher.

Comment thread index.html
Comment thread src/proc/Vigad.ts
Comment thread src/proc/TesseractHandler.ts
@Claiyc
Claiyc marked this pull request as ready for review December 11, 2022 20:41

@tonoizer tonoizer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Claiyc
Claiyc merged commit 21759bc into main Dec 11, 2022
@Claiyc
Claiyc deleted the feat/23-tesseract branch December 11, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tesseract video-to-text

2 participants