feat: tesseract implementation#58
Merged
Merged
Conversation
Member
Author
|
First part of implementation. Currently works as "call once, run once" -> should of course work as background-loop in the end. Mapping of capture areas to actual stream is not correct yet. |
Claiyc
force-pushed
the
feat/23-tesseract
branch
from
December 11, 2022 15:38
b10156b to
9ba8701
Compare
tonoizer
reviewed
Dec 11, 2022
tonoizer
left a comment
Contributor
There was a problem hiding this comment.
Over all, the implementation looks quite good, but we will see how good this works together with the regex matcher.
Claiyc
marked this pull request as ready for review
December 11, 2022 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
Once merged, this will add image-to-text translation using tesseract.js (not using regex recognition yet).
This will take capture areas into consideration (only extract text in capture areas)
As of now this will just print the recognized text into the run-view.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
fixes #23