Skip to content

fix: problem when deleting capture areas#198

Merged
Claiyc merged 15 commits into
mainfrom
fix/186-deleting-capture-area
Jun 30, 2023
Merged

fix: problem when deleting capture areas#198
Claiyc merged 15 commits into
mainfrom
fix/186-deleting-capture-area

Conversation

@tonoizer

@tonoizer tonoizer commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

PR description

There was a bug with the capture area array not really updating the rendered list properly because its not reactive etc. The solution may not be really good tho.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

fix: #186

@tonoizer
tonoizer requested a review from Claiyc June 2, 2023 09:30
@tonoizer tonoizer self-assigned this Jun 2, 2023
@tonoizer
tonoizer requested review from 2000eBe and roman533 June 2, 2023 17:16
roman533
roman533 previously approved these changes Jun 3, 2023

@roman533 roman533 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple solution, works

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a bigger issue than it seems… We cannot just reassign ca ids, as the VIGAD-API redis db structure relies on them (and therefore potential third party apps as well). A solution may be to have unique ids for capture areas (randomly generated). However for this solution we should provide the ability for a user to manually override the id of a capture area to keep consistency between sessions.

@tonoizer

tonoizer commented Jun 4, 2023

Copy link
Copy Markdown
Contributor Author

If there should be the option that the user can change the ID of a capture area i need to change a lot ofthings for example should the id then be only a number and what rules should this id follow if any ?

@Claiyc

Claiyc commented Jun 4, 2023

Copy link
Copy Markdown
Member

If there should be the option that the user can change the ID of a capture area i need to change a lot ofthings for example should the id then be only a number and what rules should this id follow if any ?

I guess it will be easier if it is alphanumeric (so we definitely won't run into issues with collisions). However it needs to be URI conform as well. Other than that, no rules that I can think of. Maybe not too long (idk, 6 characters should be enough?)

@tonoizer

tonoizer commented Jun 5, 2023

Copy link
Copy Markdown
Contributor Author

If this only alphanumeric isn't it always URI conform ?

Comment thread src/components/capture-area/CaptureAreaSearchValue/CaptureAreaSearchValue.vue Outdated
Comment thread src/components/capture-area/CaptureAreaSearchValue/CaptureAreaSearchValue.vue Outdated
Comment thread src/composables/useTokenGenerator/useTokenGenerator.ts
Comment thread src/proc/Vigad.ts
Comment thread src/proc/Vigad.ts
@tonoizer
tonoizer requested a review from Claiyc June 11, 2023 21:40
@tonoizer

Copy link
Copy Markdown
Contributor Author

This is just a workaround, because i cant fix it really

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to get the job done

@Claiyc
Claiyc merged commit a152db1 into main Jun 30, 2023
@Claiyc
Claiyc deleted the fix/186-deleting-capture-area branch June 30, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when having multiple Capture Areas, and deleting one out of order

3 participants