feat: Used notification system in existing systems#171
Merged
2000eBe merged 8 commits intoMay 22, 2023
Conversation
Signed-off-by: 2000eBe <erikab3cker@gmail.com>
2000eBe
added
Phase: Construction
RUP: Implementation
improvement
Signed-off-by: 2000eBe <erikab3cker@gmail.com>
2000eBe
marked this pull request as ready for review
May 19, 2023 16:27
tonoizer
requested changes
May 19, 2023
Claiyc
requested changes
May 21, 2023
Claiyc
requested changes
May 22, 2023
Co-authored-by: Claiyc <58397976+Claiyc@users.noreply.github.com>
…SearchValue.vue Co-authored-by: Claiyc <58397976+Claiyc@users.noreply.github.com>
https://github.com/VisualGameData/VIGAD into feat/139-use-notification-system-for-existing-systems
tonoizer
self-requested a review
May 22, 2023 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Implemented methods to use Notificationsystem in existing system (affects the Regex View and Capturing View).
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
fix: #139