Skip to content

feat:no fullscreen in settings anymore#143

Merged
roman533 merged 1 commit into
mainfrom
origin/feat/120-session-settings-dialog
May 3, 2023
Merged

feat:no fullscreen in settings anymore#143
roman533 merged 1 commit into
mainfrom
origin/feat/120-session-settings-dialog

Conversation

@roman533

@roman533 roman533 commented May 3, 2023

Copy link
Copy Markdown
Contributor

PR description

No fullscreen for the settings dialog which pops up.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

Fix: #123

@roman533 roman533 changed the title no fullscreen in settings anymore feat:no fullscreen in settings anymore May 3, 2023
@roman533
roman533 requested a review from tonoizer May 3, 2023 11:47
@tonoizer tonoizer added Phase: Construction RUP: Implementation improvement Some layout / structure / performance optimization labels May 3, 2023

@tonoizer tonoizer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Claiyc

Claiyc commented May 3, 2023

Copy link
Copy Markdown
Member

Very nice work!

@roman533
roman533 merged commit c14fcea into main May 3, 2023
@Claiyc
Claiyc deleted the origin/feat/120-session-settings-dialog branch May 3, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Some layout / structure / performance optimization Phase: Construction RUP: Implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style changes to the session settings dialog

3 participants