feat: implement notification system#129
Merged
Merged
Conversation
tonoizer
added
enhancement
tonoizer
changed the title
Claiyc
reviewed
Apr 25, 2023
Claiyc
left a comment
Claiyc
left a comment
Member
There was a problem hiding this comment.
Doesn't look bad. examples need to be removed though.
Contributor
Author
|
Yes the example need to be removed, just left them in for testing and showcasing purposed |
added 2 commits
April 25, 2023 23:51
Contributor
Author
|
I have now removed the test code, and commented the code a bit more |
Claiyc
requested changes
Apr 25, 2023
Claiyc
reviewed
Apr 25, 2023
Claiyc
reviewed
Apr 25, 2023
Contributor
Author
|
Refractored it from warning system to notification system. Additionally added the stack of the notification feature.
Currently the snakcbar notifications are all a fixed size and this should the fine for now this could be revisited and restyled in the #130 issue. |
tonoizer
changed the title
tonoizer
requested review from
Claiyc and
roman533
and removed request for
roman533
April 26, 2023 16:56
roman533
self-requested a review
April 26, 2023 20:44
roman533
previously approved these changes
Apr 26, 2023
Claiyc
requested changes
Apr 27, 2023
roman533
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
A implementation of a simple warning system where you just add and remove a Warning Object. When you do so it will display a little notification to the user, but only if the previous notification has either timed out or been closed by the user manually.
Some feedback would be very nice, because I wasn't sure what the functionalities should be.
This PR has been done in pair programming to gradually introduce @roman533 into the workprocess
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
Fix: #109