fix(build): icons not displayed properly#122
Merged
Merged
Conversation
tonoizer
added
bug
roman533
previously approved these changes
Apr 23, 2023
Contributor
|
title and icons are displayed on Ubuntu 22.04 ARM64 |
Claiyc
changed the title
Claiyc
changed the title
Claiyc
pushed a commit
that referenced
this pull request
May 3, 2023
* deleted unused images and gifs * no changes here * added logos in different formats * added icon for macOS * refactoring & build settings for linux and macOS * more build scripts * uncommented vitest coverage settings * added proper linux build settings (cherry picked from commit 76e1abe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
If have fixed the problem that for some reason that in the title bar of the application and in the taskbar in windows the icon did not display. While fixing this problem I updated a few packages and Vite in general. But also extenten the builder file for the application so it should be possible to now build the application for windows, linux, and macOS with the icons properly displayed etc.
I only know that the build for windows works for me now, so it would be nice if @roman533 maybe could check for linux aswell if everything works out there too.
To do so you need to run "npm run build:mac" and if it works you should be able to start the application and have all the icons etc.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
Fix: #80
Fix: #124