feat(session): implement settings mock up#117
Merged
Conversation
added 2 commits
April 20, 2023 16:22
Contributor
Author
Member
Contributor
Author
|
Alright, I have implemented the newly discussed design iteration on top of the old design and documented in the wiki (https://github.com/VisualGameData/VIGAD/wiki/Create-Session). |
Claiyc
previously approved these changes
Apr 20, 2023
Claiyc
left a comment
Member
There was a problem hiding this comment.
lgtm, however token generation & manual editing should be in a seperate issue
Contributor
Author
Yes this should be done in another issue, that's why I just added a placeholder token to showcase the input field functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR description
Describe your changes in detail here
The Mock-Up from #85 has been implemented. But also gave it a little thought if the design could be changed a bit, look comments below for that.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
Fix: #94