Skip to content

feat(session): implement settings mock up#117

Merged
tonoizer merged 4 commits into
mainfrom
feat/94-impl-session-settings-mock-up
Apr 20, 2023
Merged

feat(session): implement settings mock up#117
tonoizer merged 4 commits into
mainfrom
feat/94-impl-session-settings-mock-up

Conversation

@tonoizer

@tonoizer tonoizer commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

PR description

Describe your changes in detail here

The Mock-Up from #85 has been implemented. But also gave it a little thought if the design could be changed a bit, look comments below for that.

Definition Of Done (DoD)

This PR can be squashed / merged if

  • a developer is assigned
  • the PR is NOT estimated
  • the PR is labeled
  • the PR is NOT assigned to the current sprint
  • a meaningful title has been set according to https://www.conventionalcommits.org/
  • the PR is described in detail
  • the PR links to an issue
  • the PR has been reviewed

Add additional conditions here if necessary for this PR

Fix: #94

@tonoizer

tonoizer commented Apr 20, 2023

Copy link
Copy Markdown
Contributor Author

While implementing the Mock-Up I noticed something and thought why don't do it like the following, looks cleaner imo.

image

@Claiyc

Claiyc commented Apr 20, 2023

Copy link
Copy Markdown
Member

While implementing the Mock-Up I noticed something and thought why don't do it like the following, looks cleaner imo.

image

like it

@tonoizer

Copy link
Copy Markdown
Contributor Author

Alright, I have implemented the newly discussed design iteration on top of the old design and documented in the wiki (https://github.com/VisualGameData/VIGAD/wiki/Create-Session).

@Claiyc Claiyc changed the title Feat/94 impl session settings mock up feat(session): implement settings mock up Apr 20, 2023
Claiyc
Claiyc previously approved these changes Apr 20, 2023

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however token generation & manual editing should be in a seperate issue

@tonoizer

Copy link
Copy Markdown
Contributor Author

lgtm, however token generation & manual editing should be in a seperate issue

Yes this should be done in another issue, that's why I just added a placeholder token to showcase the input field functionality

@Claiyc Claiyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. See #118 for additional work

@tonoizer
tonoizer merged commit 9f89c2e into main Apr 20, 2023
@tonoizer
tonoizer deleted the feat/94-impl-session-settings-mock-up branch April 20, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the session Mockup design

3 participants