Skip to content

Expand TestRunStatus enum: added autoApproved - #34

Open
a-klimov wants to merge 1 commit into
Visual-Regression-Tracker:masterfrom
a-klimov:master
Open

Expand TestRunStatus enum: added autoApproved#34
a-klimov wants to merge 1 commit into
Visual-Regression-Tracker:masterfrom
a-klimov:master

Conversation

@a-klimov

Copy link
Copy Markdown

There is an exception when receiving autoApproved result from VRT as there is no such item in enum. Expanding enum to fix the problem

ValueError: 'autoApproved' is not a valid TestRunStatus

/usr/local/lib/python3.10/site-packages/visual_regression_tracker/visualRegressionTracker.py:99: in track
    result = self._submitTestResult(test)
/usr/local/lib/python3.10/site-packages/visual_regression_tracker/visualRegressionTracker.py:93: in _submitTestResult
    result['status'] = TestRunStatus(result['status'])
/usr/local/lib/python3.10/enum.py:385: in __call__
    return cls.__new__(cls, value)

@adabru

adabru commented Jan 25, 2026

Copy link
Copy Markdown
image

In my case, auto-approved shows as "ok" and there is no "'autoApproved". The UI also shows auto-approved as "ok" and manually approved as "approved".

pip package: visual-regression-tracker 4.9.0
docker image: visualregressiontracker/api:5.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants