fix: hide Approve/Reject variations buttons when there are no true siblings#379
Merged
nGervasyuk merged 2 commits intoJul 17, 2026
Conversation
… axis The Approve/Reject variations buttons showed whenever another run merely shared the screen name, so two runs of the same screen on different devices (e.g. iPhone + iPad, same locale) surfaced the buttons even though there was nothing to bulk-review — the dialog then listed only the run itself. Mirror the backend sibling definition: a sibling shares the name and every test-variation axis except the project's group-by axis (bulkApproveGroupBy, customTags by default). Runs differing on a fixed axis are no longer counted.
nGervasyuk
force-pushed
the
fix/variations-buttons-single-sibling
branch
from
July 16, 2026 11:46
aa2521a to
5eafbc3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Approve/Reject variations buttons appeared whenever another run in the
build merely shared the screen name. So two runs of the same screen that
differ on a fixed axis — e.g. the same screen on iPhone and iPad, same
locale — surfaced the buttons even though there was nothing to bulk-review. The
dialog then listed only the run itself (
1 of 1 matching).Fix
Mirror the backend sibling definition (
findMatchingSiblings): a sibling sharesthe screen name and every test-variation axis except the project's group-by
axis (
bulkApproveGroupBy,customTagsby default). Runs that differ on afixed axis are no longer counted as siblings, so the buttons stay hidden when
bulk review would be a no-op.
This keeps the frontend visibility check consistent with what the backend will
actually return, and stays generic to the configured group-by axis (switching a
project to group by
devicecorrectly treats different-device runs as siblings).Testing
customTags→ buttons hidden ✅device, iPhone + iPad same locale → buttons shown ✅Known limitation
hasSiblingsToReviewcounts siblings from the already-loadedtestRunslist, sowith a paginated list a sibling on another page may not be counted. The dialog
itself fetches matches from the backend, so bulk review is unaffected — only
button visibility depends on the loaded page.