Repository navigation
Conversation
The roles list names new-capability permissions no custom or legacy role holds, and the person-only keys, so the roles screen can list that gap and mark audit.forward and audit.manage. The 0008 report states whether any active person can manage roles afterwards, and that approving through chat or a person's MCP token no longer approves. Co-authored-by: craig-dt <craig@deeptempo.ai>
The permission list drops to one column when the dialog is narrow, and the new-permissions banner keeps its icon on the first line. Co-authored-by: craig-dt <craig@deeptempo.ai>
Collaborator
Author
|
🏭 Handed the merge conflicts back to the agent that opened this (1 of 3): merge conflicts with main. |
directory.sync is a new capability no custom role may hold, so the roles banner does not list it as a gap. Both changelog notes stay, and the role dialog keeps the narrow-width layout alongside the not-grantable tag. Co-authored-by: craig-dt <craig@deeptempo.ai>
craig-dt
deleted the
cursor/factory-4433-the-roles-screen-doesn-t-list-new-permissions-no-custom-role-holds-or-mark-no-effect-d9e6
branch
November 16, 2026 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4433
The roles screen never said which new-capability permissions no custom role holds, and it drew person-only permissions as ordinary checkboxes. The permission-split upgrade report also never said whether anyone could still manage roles, or that approving through chat or a person's MCP token no longer approves.
GET /api/users/roles/listnow returnsnew_permissions_unheld(catalog permissions whose origin is a new capability, held by no custom or legacy role) andperson_only(the samePERSON_ONLYset the permission check uses). The roles card lists the unheld names when there are any, and a granted person-only permission is marked "no effect for a service account". The service account edit hint is unchanged.directory.syncis a new capability too, and no custom role may hold it, so it is left off that list.0008_permission_catalogstill writes the same grants. Its report, after those grants, counts active non-deleted people whose role holdsroles.manage. When that count is zero the report says "Nobody on this install can manage roles" and namespython -m core.auth.recover_admin; otherwise it says someone can. Beside the Senior Analyst widening it states that approving an outside action through chat or a person's MCP token no longer approves it. The line is in the command output, the historyreportsentry, and theroles.revisedtrail entry.Verification
Ran
0007_conversation_generation(the revision immediately before the permission split; that revision is on the v0.9.0 chain). One had only the legacyadminrole held by an active person, plus an inactive person, a deleted person, and a service account on built-in Admin.python -m core.upgradefrom this branch wrote a0008_permission_catalogreport whose command output,history.jsonlentry, androles.revisedtrail row say "Nobody on this install can manage roles", namepython -m core.auth.recover_admin, and state the chat and MCP approval exception. Legacyadmindid not gainroles.manage.role-admin. The report says "Someone can manage roles." and still states the exception.GET /api/users/roles/listlistedcases.move,roles.manage,sessions.manage, andteams.manage. Grantingteams.manageremoved it and left the other three. Built-in roles holding all four did not empty the list. The built-in Admin dialog marks onlyaudit.forwardandaudit.manage"no effect for a service account". The Auditor role, which does not hold them, shows no marker. A service account on Admin still shows "audit.forward, audit.manage: stored on the role, no effect for a service account."Did not run
0016_retention). That head is past0008, so the revision does not run again and cannot reprint these lines. Installs that still have0008pending, including adoption from 0.7.0 and 0.8.0, are the ones that get the report.directory.syncoff the unheld list.Blocked by the machine
none