Skip to content

Mark passthrough string Verify overloads as [StringSyntax("*")] #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Jun 9, 2026
Merged

Mark passthrough string Verify overloads as [StringSyntax("*")] #1746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project>
<PropertyGroup>
<NoWarn>CA1822;CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget;xUnit1051;NU1608;NU1109</NoWarn>
<Version>31.19.0</Version>
<Version>31.19.1</Version>
<ImplicitUsings>enable</ImplicitUsings>
<LangVersion>preview</LangVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.Expecto/Verifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ public static partial class Verifier
[Pure]
public static SettingsTask Verify(
string name,
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "")
Expand All @@ -18,6 +19,7 @@ public static SettingsTask Verify(
[Pure]
public static SettingsTask Verify(
string name,
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "")
Expand All @@ -29,6 +31,7 @@ public static SettingsTask Verify(
[Pure]
public static SettingsTask Verify(
string name,
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -41,6 +44,7 @@ public static SettingsTask Verify(
[Pure]
public static SettingsTask Verify(
string name,
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.Fixie/Verifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,23 @@ public static partial class Verifier
{
[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -26,6 +29,7 @@ public static SettingsTask Verify(

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.MSTest/Verifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,23 @@ partial class Verifier
{
[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -26,6 +29,7 @@ public static SettingsTask Verify(

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.MSTest/VerifyBase_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,23 @@ partial class VerifyBase

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verifier.Verify(target, settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verifier.Verify(target, settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -28,6 +31,7 @@ public SettingsTask Verify(

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.NUnit/Verifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,23 @@ public static partial class Verifier
{
[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -26,6 +29,7 @@ public static SettingsTask Verify(

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.NUnit/VerifyBase_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,29 @@ public partial class VerifyBase
{
[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null) =>
Verifier.Verify(target, settings ?? this.settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null) =>
Verifier.Verify(target, settings ?? this.settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null) =>
Verifier.Verify(target, extension, settings ?? this.settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null) =>
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.TUnit/Verifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,23 @@ public static partial class Verifier
{
[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -26,6 +29,7 @@ public static SettingsTask Verify(

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.XunitV3/Verifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,23 @@ public static partial class Verifier
{
[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null,
[CallerFilePath] string sourceFile = "") =>
Verify(settings, sourceFile, _ => _.VerifyString(target));

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null,
Expand All @@ -26,6 +29,7 @@ public static SettingsTask Verify(

[Pure]
public static SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null,
Expand Down
4 changes: 4 additions & 0 deletions src/Verify.XunitV3/VerifyBase_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,29 @@ public partial class VerifyBase
{
[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
string? target,
VerifySettings? settings = null) =>
Verifier.Verify(target, settings ?? this.settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
VerifySettings? settings = null) =>
Verifier.Verify(target, settings ?? this.settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
string? target,
string extension,
VerifySettings? settings = null) =>
Verifier.Verify(target, extension, settings ?? this.settings, sourceFile);

[Pure]
public SettingsTask Verify(
[StringSyntax("*")]
Task<string> target,
string extension,
VerifySettings? settings = null) =>
Expand Down
8 changes: 4 additions & 4 deletions src/Verify/Verifier/InnerVerifier_String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@

partial class InnerVerifier
{
public async Task<VerifyResult> VerifyString(Task<string> task)
public async Task<VerifyResult> VerifyString([StringSyntax("*")] Task<string> task)
{
var value = await task;
return await VerifyString(value);
}

public Task<VerifyResult> VerifyString(string? value) =>
public Task<VerifyResult> VerifyString([StringSyntax("*")] string? value) =>
VerifyInner(value, null, emptyTargets, true, false);

public async Task<VerifyResult> VerifyString(Task<string> task, string extension)
public async Task<VerifyResult> VerifyString([StringSyntax("*")] Task<string> task, string extension)
{
var value = await task;
return await VerifyString(value, extension);
}

public Task<VerifyResult> VerifyString(string? value, string extension) =>
public Task<VerifyResult> VerifyString([StringSyntax("*")] string? value, string extension) =>
VerifyInner(
[
new(extension, value ?? "null")
Expand Down
Loading