Various refactorings mainly focused on the LineGraph exporter#53
Merged
Various refactorings mainly focused on the LineGraph exporter#53
Conversation
ibbem
force-pushed
the
benjamin/refactoring
branch
2 times, most recently
from
4fb05e6 to
a85face
Compare
pmbittner
requested changes
Oct 17, 2022
Member
pmbittner
left a comment
pmbittner
left a comment
There was a problem hiding this comment.
Only minor comments. It is not easy to see through all the changes at once but they make a good impression and seem to simplify a lot. Greatly appreciated.
Behavioural changes: - `EditClassValidationTask` doesn't add export options to the metadata anymore because it doesn't actually export anything. - Bug fix: The tree preprocessing in `MiningTask` was run twice: First for the line graph export and second directly by the `call` method.
ibbem
force-pushed
the
benjamin/refactoring
branch
from
a85face to
248f53f
Compare
This was referenced Oct 17, 2022
This test needs manual inspection of the results.
ibbem
force-pushed
the
benjamin/refactoring
branch
from
248f53f to
1a98016
Compare
pmbittner
approved these changes
Oct 24, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if the the last commit
9e37848a51f67fbddc20350ea3b279ea7c435b4bbreaks anything, because, to me, the intent of keeping all line graphs in memory was unclear.Notable behavioral changes:
EditClassValidationTaskdoesn't add export options to the metadata anymore because it doesn't actually export anything.MiningTaskwas run twice:First for the line graph export and second directly by the
callmethod.