fix: duplicate score sets appearing in GET results#690
Draft
bencap wants to merge 1 commit intorelease-2026.1.2from
Draft
fix: duplicate score sets appearing in GET results#690bencap wants to merge 1 commit intorelease-2026.1.2from
bencap wants to merge 1 commit intorelease-2026.1.2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of superseded score sets to prevent duplicate results and enhances the clarity and structure of related tests. The main change ensures that when multiple unpublished score sets supersede the same published score set, only one instance of the published score set is returned to non-owners. Several test cases are updated for consistency and readability, and a new test is added to verify the deduplication logic.
Score set deduplication logic:
get_experiment_score_setsinexperiments.pyto deduplicate score sets by their IDs, ensuring that the same visible ancestor score set is not returned multiple times when traversing superseded chains.Testing improvements:
test_non_owner_searches_multiple_unpublished_superseding_score_sets_no_duplicatesto verify that non-owners see only a single instance of a published score set even if multiple unpublished score sets supersede it.test_update_experiment_keywords,test_update_experiment_keywords_case_insensitive) for better readability and maintainability. [1] [2]