Duskull, Kecleon, Kangaskhan Overlays + Peripherals#404
Open
HappyLappy1 wants to merge 127 commits into
Open
Conversation
Tests are passing on my end. Somehow I have those now?
The headers look like a nightmare to properly format without actual clang. So I'll pass on that for now.
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
…ppy1/pmdsky-debug into Spring-Cleaning-SwapShop
assidion2
reviewed
Jun 21, 2026
Contributor
There was a problem hiding this comment.
You can also probably document the inner function FUN_0200d398 as MaybeGetFormattedItemName
params 1-3: same as in your functions
param 4: should_color_name (bool)
param 5: space_align_non_sticky_items (bool, whether to add an extra space before non sticky items to align them with sticky ones)
UsernameFodder
requested changes
Jun 21, 2026
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.