Repository navigation
fix(mcp): preserve nested schema references in tool signatures - #2261
Draft
aryasaatvik wants to merge 1 commit into
Draft
aryasaatvik wants to merge 1 commit into
aryasaatvik wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account-routed imported tools currently advertise
unknownfor referenced input fields and responses because their JSON Schema references point into account branches. Project those local references into distinct root definitions before rendering signatures, preserving each account's types and recursive references.The projection changes only the schemas passed to CodeMode; original tool schemas and validation remain intact. Existing account-routing coverage now requires distinct account literals, escaped definition names, recursive sibling fields, and a typed output consumer.
Four focused self-host scenarios pass. The regression fails against the original renderer at the expected
value: "work"assertion. Fullbun run checkremains blocked by twelve existing implicit-any errors in the desktop E2E support and release scenario; core typechecking, formatting, linting, dependency patches, and the remaining contract checks pass.