Repository navigation
Show the account menu on every account row of an app - #2239
Open
leoisadev1 wants to merge 2 commits into
Open
leoisadev1 wants to merge 2 commits into
leoisadev1 wants to merge 2 commits into
Conversation
The menu on an app's Accounts tab only showed on the selected account, and only on hover. Every row now shows it. An unselected account's menu offers Rename and Update credentials but not Remove. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dialog edits the account's name and description, and the Accounts page already calls it Edit details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leoisadev1
marked this pull request as ready for review
October 9, 2026 17:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On an app's Accounts tab, the
···menu only showed on the selected account, and only on hover. Unselected accounts had no menu, so you couldn't edit one or update its credentials from the app. Every row now shows the menu. An unselected account's menu has Edit details and Update credentials but not Remove, since the profile doesn't select it. The menu item that opens the name and description dialog is now called Edit details, as it already is on the Accounts page.Evidence
local-account-naming.spec.tsfails at "Unselected accounts show their menu without hover" on the original code.After: it passes. It also checks that the unselected account's menu lists only Edit details and Update credentials and that both dialogs open from it.
Not checked: mobile width and dark mode screenshots, and the Cloud target in a browser (hosted code is covered by the self-host scenarios).
Merge Danger
Door: two-way. It's UI only, with no stored state.
Blast radius: the Accounts tab of every app, local and hosted. If it's wrong, an unselected account shows a menu with the wrong items.
Created with Claude Opus 5.5 in T3 Code.