Skip to content

Show the account menu on every account row of an app - #2239

Open
leoisadev1 wants to merge 2 commits into
UsefulSoftwareCo:v2from
leoisadev1:leoplayz317/exe-10-show-the-account-menu-on-every-account-row-of-an-app
Open

leoisadev1 wants to merge 2 commits into
UsefulSoftwareCo:v2from
leoisadev1:leoplayz317/exe-10-show-the-account-menu-on-every-account-row-of-an-app

Conversation

@leoisadev1

@leoisadev1 leoisadev1 commented Oct 9, 2026 •

Copy link
Copy Markdown

Summary

On an app's Accounts tab, the ··· menu only showed on the selected account, and only on hover. Unselected accounts had no menu, so you couldn't edit one or update its credentials from the app. Every row now shows the menu. An unselected account's menu has Edit details and Update credentials but not Remove, since the profile doesn't select it. The menu item that opens the name and description dialog is now called Edit details, as it already is on the Accounts page.

 AppAccounts (packages/ui)
-  {bound && removeAccountAction(slot, id, label)}
+  {removeAccountAction(slot, id, label, bound)}
 AccountBindingMenu
-  ··· button: opacity-0 until hover or focus
+  ··· button: always visible
-  Remove
+  Remove only when bound
-  Rename
+  Edit details
 local + hosted app-accounts pages
+  no menu for an unselected account with no saved actions

Evidence

Before After
Before: only the selected account has a menu, on hover After: every account shows its menu
After: menu opened from Supplied name, which isn't selected
Menu on an unselected account with Edit details and Update credentials
  • Before: local-account-naming.spec.ts fails at "Unselected accounts show their menu without hover" on the original code.
    After: it passes. It also checks that the unselected account's menu lists only Edit details and Update credentials and that both dialogs open from it.
  • On self-host, the account connection, grouped accounts, profile picker and member controls scenarios pass.

Not checked: mobile width and dark mode screenshots, and the Cloud target in a browser (hosted code is covered by the self-host scenarios).

local-account-naming.spec.ts
account-naming.spec.ts
app-account-picker.spec.ts
profile-picker.spec.ts
member-controls.spec.ts
account-connection-query.spec.ts
grouped-accounts.spec.ts

Merge Danger

Door: two-way. It's UI only, with no stored state.

Blast radius: the Accounts tab of every app, local and hosted. If it's wrong, an unselected account shows a menu with the wrong items.

Created with Claude Opus 5.5 in T3 Code.

leoisadev1 and others added 2 commits October 9, 2026 13:11
The menu on an app's Accounts tab only showed on the selected account,
and only on hover. Every row now shows it. An unselected account's menu
offers Rename and Update credentials but not Remove.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dialog edits the account's name and description, and the Accounts
page already calls it Edit details.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leoisadev1
leoisadev1 marked this pull request as ready for review October 9, 2026 17:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant