Repository navigation
Stamp client identity on MCP execution spans - #1621
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | d9ab930 | Commit Preview URL Branch Preview URL |
Aug 17 2026, 04:36 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | d9ab930 | Aug 17 2026, 04:37 PM |
RhysSullivan
marked this pull request as ready for review
August 17, 2026 16:47
Merged
omega-alpha-matt Bot
pushed a commit
to airbooksio/executor
that referenced
this pull request
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Execution spans (execute, execute-action, resume, and their descendants) now carry
mcp.client.name/mcp.client.version/mcp.client.titlealongside the existingmcp.request.session_id/mcp.rpc.idjoin keys.Why: the initialize-reported
clientInfoonly existed on the initialize request span, which carries no session id yet, so execution telemetry could not be segmented by client (per-client search/tool-call funnels required a user-agent proxy).How:
initialize(getClientVersion) and re-sync on the sameoninitializedhook that syncs apps capabilities.persistClientInfo, mirroringpersistAppsEnabled) so attribution survives cold restores; a newrestoredClientInfoconfig seeds the rebuilt server._metaclientInfo (falling back to theinitializebody) and thread it throughModernMcpServerRequestOptions; the DO persists what a request reports.The identity feeds span attributes only, never behavior. Absent identity emits no keys rather than empty strings.
Tests: span attribution through a real MCP client, the
onClientInfoChangepersistence contract, and the body parser.format:check,lint,typecheck, and the mcp/cloudflare/cloud test suites are green.