Conversation
jj16791
approved these changes
May 19, 2023
FinnWilkinson
approved these changes
May 19, 2023
rahahahat
approved these changes
May 19, 2023
Contributor
|
#rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Tealeaf compiled to RISC-V a series of memcpy's are performed. The main body of a memcpy is a short loop, loading from one memory location and storing to another byte by byte. As this short loop is repeated it causes the loop buffer to be filled which is then used to supply decode. On one of these calls to memcpy, the loop buffer is filled just as the loop should finish iterating.
In the original implementation when the loop buffer is in the state FILLING the fetch unit fetches the final branch of this loop. As this is at the loop boundary address the loop buffer eagerly changes state to SUPPLYING and stops fetching more instructions. It disregards the branch predictors' "not taken" prediction which should cause the instruction at pc+4 to be fetched; instead the fetch tick is completed for this cycle and in the next cycle the loop buffer supplies decode (along with the not taken prediction given when filling) which then ultimately causes an infinite loop which grows SimEngs memory until the host system memory fills and the OS kills it.
To fix this, when the loop buffer should finish filling the branch prediction is checked to determine whether the buffer should be used to supply decode or not.