Skip to content

Fix for sve FNEG (predicated) instruction#230

Merged
FinnWilkinson merged 11 commits intodevfrom
minibude-output-error
Jun 14, 2022
Merged

Fix for sve FNEG (predicated) instruction#230
FinnWilkinson merged 11 commits intodevfrom
minibude-output-error

Conversation

@FinnWilkinson
Copy link
Copy Markdown
Contributor

Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.

Copy link
Copy Markdown

@BraveSirRobbo BraveSirRobbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what most of the code is doing, mostly looks good to me apart from doubleRoundToNearestTiesToEven

Comment thread src/include/simeng/arch/aarch64/helpers/auxiliaryFunctions.hh Outdated
Comment thread src/include/simeng/arch/aarch64/helpers/auxiliaryFunctions.hh
Comment thread src/include/simeng/arch/aarch64/helpers/sve.hh Outdated
Copy link
Copy Markdown

@BraveSirRobbo BraveSirRobbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

Comment thread src/include/simeng/arch/aarch64/helpers/sve.hh Outdated
@dANW34V3R
Copy link
Copy Markdown
Contributor

Looks good

@dANW34V3R dANW34V3R closed this Jun 9, 2022
@FinnWilkinson FinnWilkinson reopened this Jun 9, 2022
@FinnWilkinson FinnWilkinson merged commit bafc39e into dev Jun 14, 2022
tomhepworth pushed a commit that referenced this pull request Jun 25, 2022
Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.
jj16791 pushed a commit that referenced this pull request Jul 28, 2022
Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.
jj16791 pushed a commit that referenced this pull request Aug 1, 2022
Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.
tomhepworth pushed a commit that referenced this pull request Aug 13, 2022
Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.
jj16791 pushed a commit that referenced this pull request Oct 17, 2022
Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.
@FinnWilkinson FinnWilkinson deleted the minibude-output-error branch October 18, 2022 15:59
jj16791 pushed a commit that referenced this pull request Oct 21, 2022
Fixes output error present for miniBUDE when compiled with GCC-10.3.0 targeting armv8.4-a+sve, caused by an incorrect implementation of the FNEG sve instruction.

Additionally, other SVE instructions were updated to accomodate for optional patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants