0.9.2 Release#215
Merged
FinnWilkinson merged 6 commits intomainfrom Feb 4, 2022
Merged
Conversation
This PR contains some minor bug fixes including: - An issue whereby fresh clones/installs of SimEng which had no specialFiles directory. It would fail in the RemoveExistingSFDir function of SpecialFileDirGen.cc due to No such file or directory error. - Removal of use of the getdents64 system call in favour of custom implementation to avoid re-occurring unpredictable issues whereby builds fail due to the system calls inclusion.
This main objective of this Pull Request was to reduce the amount of repeated code in the Instruction_execute.cc switch case. Currently, each instruction will have its accosiated code contained within its switch case; but as there are many variations of the same (or similar) instructions this leads to alot of repeated code. To combat this, 13 new header files have been created which contain 'Helper Functions' which are type agnostic, and in some cases accomodate multiple different instructions by taking in a Lambda function as part of the function's parameters (e.g. a single LogicOperation helper function could perform AND, XOR, EOR, etc). Most of the currently supported instructions now use these helper functions, with the exception of LOAD and STORE type instructions (excluded to not interfere with ongoing Micro-Op support), and single line instructions (e.g. type conversion, mov, excluded due to having a small footprint in the code already). The work included within this PR is a first step towards complete use of helper functions. As well as converting LOAD and STORE instructions to use helper functions, there are plans to further generalise the currently implemented helper functions to both reduce their code footprint and to make them easier to utilise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bring SimEng up to Release 0.9.2.
Contained are some minor bug fixes (such as issues with the
getdent64syscall on certain OS's), and a reconfiguration of the instruction execution logic via the use of helper functions.Such a reconfiguration was done in order to reduce repeated code in
Instruction_execute.ccby making generic helper functions, and to make supporting new instructions quicker and easier.The Developer Docs have also been updated to reflect the change in implementing new instructions.