Fixed issue where long sounds cannot be converted to frequencies#7
Merged
press-stuart merged 1 commit intomasterfrom Apr 10, 2025
Merged
Fixed issue where long sounds cannot be converted to frequencies#7press-stuart merged 1 commit intomasterfrom
press-stuart merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes:
sound_fft/functionsimports a re-implemented version ofvector_to_listsound_fft/indexsound_fft/listNow the
sound_fftmethods work with longer sounds. The new bottleneck is probably the application of the filter itself? It should be safe to use sounds of duration up to 5 seconds with user-defined filters in Source usingmap(needs further testing). Using library-definedlow_pass_filterandhigh_pass_filter, very long sounds (e.g. 1 min) seem to run fine.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: