Skip to content

Fixed issue where long sounds cannot be converted to frequencies#7

Merged
press-stuart merged 1 commit intomasterfrom
stot
Apr 10, 2025
Merged

Fixed issue where long sounds cannot be converted to frequencies#7
press-stuart merged 1 commit intomasterfrom
stot

Conversation

@press-stuart
Copy link
Copy Markdown
Collaborator

Description

Changes:

  • sound_fft/functions imports a re-implemented version of vector_to_list
  • added my (Stuart's) full name to sound_fft/index
  • removed unneeded methods from sound_fft/list

Now the sound_fft methods work with longer sounds. The new bottleneck is probably the application of the filter itself? It should be safe to use sounds of duration up to 5 seconds with user-defined filters in Source using map (needs further testing). Using library-defined low_pass_filter and high_pass_filter, very long sounds (e.g. 1 min) seem to run fine.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@press-stuart press-stuart merged commit e944920 into master Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant