Add features for all supported formats#13
Open
linkmauve wants to merge 1 commit intoUniversalGameExtraction:masterfrom
Open
Add features for all supported formats#13linkmauve wants to merge 1 commit intoUniversalGameExtraction:masterfrom
linkmauve wants to merge 1 commit intoUniversalGameExtraction:masterfrom
Conversation
Building this library on my quad-core Cortex-A55 takes 1:20, which is too long to be pleasant to work on it. With only the bc1 feature enabled for instance, that goes down to 1.95s, or a factor 40 in compilation time. With this change, all supported formats are still enabled by default, but can be disabled by setting default-features = false in the Cargo.toml (or passing --no-default-features to cargo), and then enabled independently. The pvrtc or crunch features without the alloc feature don’t build, but that was the case before as well so I’m not fixing that here. Do you want me to work on adding CI testing for all relevant combinations of features, or is that unnecessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building this library on my quad-core Cortex-A55 takes 1:20, which is too long to be pleasant to work on it. With only the
bc1feature enabled for instance, that goes down to 1.95s, or a factor 40 in compilation time.With this change, all supported formats are still enabled by default, but can be disabled by setting
default-features = falsein theCargo.toml(or passing--no-default-featurestocargo), and then enabled independently.The
pvrtcorcrunchfeatures without theallocfeature don’t build, but that was the case before as well so I’m not fixing that here.Do you want me to work on adding CI testing for all relevant combinations of features, or is that unnecessary?